fixing #9483, Remove #[abi = "foo"] attributes from codebase. #9601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -33,14 +33,14 @@ arguments directly while performing minimal allocations. | |||
|
|
|||
| Some examples of the `format!` extension are: | |||
|
|
|||
| ```rust | |||
| ~~~{.rust} | |||
There was a problem hiding this comment.
This is incorrect, please leave them as they were.
|
You appear to have picked up some extra commits, would it be possible to remove the first 3 and squash the last 2 together? |
|
On 09/29/2013 11:49 AM, Huon Wilson wrote:
|
|
I need to clean up my commits first, will open this later |
atopia
added a commit
to atopia/rust
that referenced
this pull request
Jan 21, 2022
- Fix style errors.
- L4-bender does not yet support dynamic linking.
- Stack unwinding is not yet supported for x86_64-unknown-l4re-uclibc.
For now, just abort on panics.
- Use GNU-style linker options where possible. As suggested by review:
- Use standard GNU-style ld syntax for relro flags.
- Use standard GNU-style optimization flags and logic.
- Use standard GNU-style ld syntax for --subsystem.
- Don't read environment variables in L4Bender linker. Thanks to
CARGO_ENCODED_RUSTFLAGS introduced in rust-lang#9601, l4-bender's arguments can
now be passed from the L4Re build system without resorting to custom
parsing of environment variables.
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Oct 20, 2022
[`match_single_binding`] Add curlies for more cases to fix suggestion causes error Fixes rust-lang#9575 changelog: [`match_single_binding`]: Add curlies for scrutinees with side effects for more cases
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed and checked with "make check"