Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stabilize assert_matches #95886

Closed
wants to merge 1 commit into from

Conversation

luqmana
Copy link
Member

@luqmana luqmana commented Apr 10, 2022

Closes #82775

@rustbot modify labels: +T-libs-api

@rust-highfive
Copy link
Collaborator

r? @kennytm

(rust-highfive has picked a reviewer for you, use r? to override)

@rustbot rustbot added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. labels Apr 10, 2022
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 10, 2022
@luqmana
Copy link
Member Author

luqmana commented Apr 10, 2022

#82775 was approved in Jan so I figured I'd open this to get things going.

There was some confusion about whether or not we'd stabilize it in its current path (std::assert_matches::assert_matches). As far as I can tell that is the plan and it'll be considered for adding to the prelude in the next edition.

@luqmana
Copy link
Member Author

luqmana commented Apr 12, 2022

r? @m-ou-se

@rust-highfive rust-highfive assigned m-ou-se and unassigned kennytm Apr 12, 2022
@m-ou-se
Copy link
Member

m-ou-se commented Apr 12, 2022

This PR is stabilizing this macro as std::assert_matches::assert_matches!() rather than std::assert_matches!(). The assert_matches module was just a temporary hack to fix some breakage. This problem hasn't been resolved yet on the tracking issue (#82775).

@luqmana
Copy link
Member Author

luqmana commented Apr 12, 2022

Ah,

This PR is stabilizing this macro as std::assert_matches::assert_matches!() rather than std::assert_matches!(). The assert_matches module was just a temporary hack to fix some breakage. This problem hasn't been resolved yet on the tracking issue (#82775).

Ah, I thought I saw a comment about a T-libs meeting deciding on the module approach for now but looks like there wasn't final consensus there. I'll close this for now thanks.

@luqmana luqmana closed this Apr 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tracking Issue for assert_matches
5 participants