-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tell users that ||
operators are not currently supported in let chain expressions
#95314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
label
Mar 25, 2022
r? @lcnr (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
label
Mar 25, 2022
lcnr
reviewed
Mar 25, 2022
compiler/rustc_infer/src/infer/error_reporting/nice_region_error/static_impl_trait.rs
Outdated
Show resolved
Hide resolved
c410-f3r
force-pushed
the
aqui-vamos-nos
branch
from
March 25, 2022 21:51
d6d16e5
to
9e0b7c3
Compare
can you update the pr description + title? after that r=me, thanks @bors delegate+ |
✌️ @c410-f3r can now approve this pull request |
c410-f3r
changed the title
Minor
Tell users that Mar 28, 2022
let_chains
modifications||
operators are not currently supported in let chain expressions
📌 Commit 9e0b7c3 has been approved by |
bors
added
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Mar 28, 2022
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 28, 2022
Rollup of 6 pull requests Successful merges: - rust-lang#95301 (Remove `Nonterminal::NtTT`.) - rust-lang#95314 (Tell users that `||` operators are not currently supported in let chain expressions) - rust-lang#95350 (resolve: Simplify some diagnostic code to avoid an ICE) - rust-lang#95370 ([bootstrap] Don't print `Suite not skipped` unless `--verbose` is set) - rust-lang#95390 (Ignore doc comments in a declarative macro matcher.) - rust-lang#95401 (Remove duplicated and unused test files) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tells that
||
operators are not currently supported instead of not allowed. See #53667 (comment)In other words, this PR is pretty much trivial.