rustbuild: Fix LLVM build with LLD on windows-gnu targets #95266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
@bors rollup |
mati865
approved these changes
Mar 24, 2022
jonhoo
approved these changes
Mar 24, 2022
|
We may need a more comprehensive change to deal with #94983, but I think this is the right thing to do in the short term at least. |
|
Yeah statically linking libc++ is tricky because it can use different low level libraires like libc++abi, libsupc++ or libcxxrt and sometimes depending on how it was building requires them to be passed. |
|
The change landed as a part of #95255. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #94832 (comment)
(I currently have to add this to all my PRs because otherwise nothing builds on my machine.)