Support other types of pluralization in pluralize macro #94958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-compiler
|
Some changes occured to the CTFE / Miri engine cc @rust-lang/miri |
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
📌 Commit 6285e9207bb98837e9973631aef4109b63bddd00 has been approved by |
bors
added
S-waiting-on-bors
oli-obk
added
A-diagnostics
This comment has been minimized.
This comment has been minimized.
|
@bors r- looks like some cases actually changed visible behaviour, maybe the previous code had a bug? |
bors
added
S-waiting-on-author
oli-obk
reviewed
Mar 15, 2022
|
re-r? @oli-obk |
|
@bors r+ rollup |
|
📌 Commit 3bf9124 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 15, 2022
…askrgr Rollup of 4 pull requests Successful merges: - rust-lang#94810 (debuginfo: Fix bug in type name generation for dyn types with associated types but no other generic arguments.) - rust-lang#94947 (fix typos) - rust-lang#94956 (Fix small typo in FIXME) - rust-lang#94958 (Support other types of pluralization in pluralize macro) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
Mar 16, 2022
…s, r=estebank Extend the irrefutable_let_patterns lint to let chains Implements the suggestion from rust-lang#94927 (comment) We only look for complete suffixes or prefixes of irrefutable let patterns, so that an irrefutable let pattern in a chain surrounded by refutable ones is not linted, as it is an useful pattern that has no low-cost replacement (unlike suffixes or prefixes which can just be copied outside of the `if`: either into the `if`'s block, or the block surrounding the `if`). If all patterns in a let chain are irrefutable, we lint as well. Depends on rust-lang#94958 ~~so I included it into the PR for now~~ *which has been merged since*. r? `@estebank` cc `@joshtriplett` `@c410-f3r`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.