Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit docs on consistency of PartialOrd and PartialEq #94620

Merged
merged 1 commit into from
Mar 5, 2022

Conversation

pierwill
Copy link
Member

@pierwill pierwill commented Mar 4, 2022

Use ordered list to make the information about implementations more readable.

Use ordered list to make the information about implementations more readable.
@rust-highfive
Copy link
Collaborator

r? @yaahc

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 4, 2022
@pierwill
Copy link
Member Author

pierwill commented Mar 4, 2022

Just a style suggestion. Feel free to close if it doesn't feel like an improvement. :)

@yaahc
Copy link
Member

yaahc commented Mar 4, 2022

I think its a welcome improvement and significantly reduces how noisy it looks without reducing the amount of information being communicated. Thank you!

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Mar 4, 2022

📌 Commit f0257b1 has been approved by yaahc

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 4, 2022
@Dylan-DPC
Copy link
Member

Personally i like the idea but i feel it could be more confusing as people need to look up the numbers after reading the comment so i'm not sure there's much gain in this.

@yaahc
Copy link
Member

yaahc commented Mar 4, 2022

Personally i like the idea but i feel it could be more confusing as people need to look up the numbers after reading the comment so i'm not sure there's much gain in this.

noted. cc @rust-lang/libs-api to see if anyone else has strong feelings for or against this change.

Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Mar 5, 2022
…=yaahc

Edit docs on consistency of `PartialOrd` and `PartialEq`

Use ordered list to make the information about implementations more readable.
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 5, 2022
Rollup of 6 pull requests

Successful merges:

 - rust-lang#94446 (UNIX `remove_dir_all()`: Try recursing first on the slow path)
 - rust-lang#94460 (Reenable generator drop tracking tests and fix mutation handling)
 - rust-lang#94620 (Edit docs on consistency of `PartialOrd` and `PartialEq`)
 - rust-lang#94624 (Downgrade `#[test]` on macro call to warning)
 - rust-lang#94626 (Add known-bug directive to issue rust-lang#47511 test case)
 - rust-lang#94631 (Fix typo in c-variadic)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit a3fe63e into rust-lang:master Mar 5, 2022
@rustbot rustbot added this to the 1.61.0 milestone Mar 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants