Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update Miri #94437

Merged
merged 1 commit into from
Feb 28, 2022
Merged

update Miri #94437

merged 1 commit into from
Feb 28, 2022

Conversation

RalfJung
Copy link
Member

Fixes #94318
r? @ghost

@RalfJung
Copy link
Member Author

@bors r+ p=1
Cc @rust-lang/miri

@bors
Copy link
Contributor

bors commented Feb 28, 2022

📌 Commit a538b18 has been approved by RalfJung

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Feb 28, 2022
@bors
Copy link
Contributor

bors commented Feb 28, 2022

⌛ Testing commit a538b18 with merge ec0ab61...

@bors
Copy link
Contributor

bors commented Feb 28, 2022

☀️ Test successful - checks-actions
Approved by: RalfJung
Pushing ec0ab61 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Feb 28, 2022
@bors bors merged commit ec0ab61 into rust-lang:master Feb 28, 2022
@rustbot rustbot added this to the 1.61.0 milestone Feb 28, 2022
@rust-highfive
Copy link
Collaborator

📣 Toolstate changed by #94437!

Tested on commit ec0ab61.
Direct link to PR: #94437

🎉 miri on windows: build-fail → test-pass (cc @oli-obk @RalfJung @eddyb).
🎉 miri on linux: build-fail → test-pass (cc @oli-obk @RalfJung @eddyb).

rust-highfive added a commit to rust-lang-nursery/rust-toolstate that referenced this pull request Feb 28, 2022
@rust-highfive
📣 Toolstate changed by rust-lang/rust#94437!
09c710c 
Tested on commit rust-lang/rust@ec0ab61.
Direct link to PR: <rust-lang/rust#94437>

🎉 miri on windows: build-fail → test-pass (cc @oli-obk @RalfJung @eddyb).
🎉 miri on linux: build-fail → test-pass (cc @oli-obk @RalfJung @eddyb).
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (ec0ab61): comparison url.

Summary: This benchmark run did not return any relevant results. 4 results were found to be statistically significant but too small to be relevant.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

@RalfJung RalfJung deleted the miri branch March 1, 2022 23:24
@compiler-errors compiler-errors mentioned this pull request Nov 4, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.61.0
Development

Successfully merging this pull request may close these issues.

miri no longer builds after rust-lang/rust#94314
5 participants
@RalfJung @bors @rust-highfive @rust-timer @rustbot