Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make TLS __getit #[inline(always)] on non-Windows #94373

Merged
merged 1 commit into from
Feb 27, 2022
Merged

Make TLS __getit #[inline(always)] on non-Windows #94373

merged 1 commit into from
Feb 27, 2022

Conversation

erikdesjardins
Copy link
Contributor

@erikdesjardins erikdesjardins commented Feb 25, 2022 •
edited
Loading

This may improve perf, and/or stop externs perf benchmarks from being flaky.

r? @ghost

@erikdesjardins erikdesjardins mentioned this pull request Feb 25, 2022
Merged
@nikic
Copy link
Contributor

nikic commented Feb 25, 2022

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Feb 25, 2022
@bors
Copy link
Contributor

bors commented Feb 25, 2022

⌛ Trying commit 2d6d30f with merge 7cda7542c9f3a3ff64bb19fd207c2d03fb2ef36c...

@bors
Copy link
Contributor

bors commented Feb 25, 2022

☀️ Try build successful - checks-actions
Build commit: 7cda7542c9f3a3ff64bb19fd207c2d03fb2ef36c (7cda7542c9f3a3ff64bb19fd207c2d03fb2ef36c)

@rust-timer
Copy link
Collaborator

Queued 7cda7542c9f3a3ff64bb19fd207c2d03fb2ef36c with parent d981633, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (7cda7542c9f3a3ff64bb19fd207c2d03fb2ef36c): comparison url.

Summary: This benchmark run shows 1 relevant improvement 🎉 to instruction counts.

  • Largest improvement in instruction counts: -2.9% on incr-patched: b9b3e592dd cherry picked builds of style-servo debug

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Feb 26, 2022
@erikdesjardins erikdesjardins mentioned this pull request Feb 26, 2022
Merged
@Mark-Simulacrum
Copy link
Member

@bors r+

I think this likely won't hurt, at minimum, and may help fix some perf noise.

@bors
Copy link
Contributor

bors commented Feb 26, 2022

📌 Commit 2d6d30f has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 26, 2022
@bors
Copy link
Contributor

bors commented Feb 27, 2022

⌛ Testing commit 2d6d30f with merge 035a717...

@bors
Copy link
Contributor

bors commented Feb 27, 2022

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing 035a717 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Feb 27, 2022
@bors bors merged commit 035a717 into rust-lang:master Feb 27, 2022
@rustbot rustbot added this to the 1.61.0 milestone Feb 27, 2022
@bors bors mentioned this pull request Feb 27, 2022
Merged
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (035a717): comparison url.

Summary: This benchmark run shows 1 relevant improvement 🎉 to instruction counts.

  • Largest improvement in instruction counts: -3.0% on incr-patched: b9b3e592dd cherry picked builds of style-servo debug

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

@erikdesjardins erikdesjardins deleted the getitinl branch February 27, 2022 08:12
This was referenced Mar 1, 2022
Merged
Merged
Merged
Merged
Merged
@Mark-Simulacrum Mark-Simulacrum mentioned this pull request Mar 1, 2022
Merged
@Mark-Simulacrum Mark-Simulacrum mentioned this pull request Apr 16, 2022
Closed
erikdesjardins added a commit to erikdesjardins/rust that referenced this pull request Apr 17, 2022
@erikdesjardins
Revert "Auto merge of rust-lang#94373 - erikdesjardins:getitinl, r=Ma…
6a8a8f5 
…rk-Simulacrum"

This reverts commit 035a717, reversing
changes made to 761e888.
erikdesjardins added a commit to erikdesjardins/rust that referenced this pull request Apr 17, 2022
@erikdesjardins
Revert "Auto merge of rust-lang#94373 - erikdesjardins:getitinl, r=Ma…
b0d9c42 
…rk-Simulacrum"

This reverts commit 035a717, reversing
changes made to 761e888.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.61.0
Development

Successfully merging this pull request may close these issues.
6 participants
@erikdesjardins @nikic @rust-timer @bors @Mark-Simulacrum @rustbot