Add one more case to avoid ICE #94355
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-compiler
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
Thanks for the PR, @ouz-a! The test location looks good to me -- however, I don't know this code, so I'm going to re-assign. |
oli-obk
reviewed
Feb 25, 2022
|
@bors r+ rollup |
|
📌 Commit 8cbd6e825b303d591af5e3b743a100b7b2ed077d has been approved by |
bors
added
S-waiting-on-bors
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
ouz-a
commented
Feb 25, 2022
|
@bors r+ rollup |
|
📌 Commit a625de270db5e582a88fb2a0f11d8d5926fa5ac0 has been approved by |
|
Squashed commits -- please try to keep the history a little more tidy in the future. @bors r=oli-bok |
|
📌 Commit 8c96487 has been approved by |
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Feb 25, 2022
Add one more case to avoid ICE Fix for the rust-lang#94291, added one more case to related function to avoid ICE. Not sure if my test is in the correct place 😅
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 26, 2022
…askrgr Rollup of 5 pull requests Successful merges: - rust-lang#93603 (Populate liveness facts when calling `get_body_with_borrowck_facts` without `-Z polonius`) - rust-lang#93870 (Fix switch on discriminant detection in a presence of coverage counters) - rust-lang#94355 (Add one more case to avoid ICE) - rust-lang#94363 (Remove needless borrows from core::fmt) - rust-lang#94377 (`check_used` should only look at actual `used` attributes) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
ah sorry about that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for the #94291, added one more case to related function to avoid ICE.
Not sure if my test is in the correct place 😅