Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline a few trivial conversion functions #94021

Merged
merged 4 commits into from
Feb 16, 2022
Merged

Conversation

tmiasko
Copy link
Contributor

@tmiasko tmiasko commented Feb 15, 2022

No description provided.

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Feb 15, 2022
@rust-highfive
Copy link
Collaborator

r? @nagisa

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive
Copy link
Collaborator

⚠️ Warning ⚠️

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 15, 2022
@tmiasko
Copy link
Contributor Author

tmiasko commented Feb 15, 2022

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Feb 15, 2022
@bors
Copy link
Contributor

bors commented Feb 15, 2022

⌛ Trying commit 8652869c9daa06e306d9f0c169beef1345c7437b with merge efbb34e2a6d22a3aa83b7b108efed88c95141f59...

@bors
Copy link
Contributor

bors commented Feb 15, 2022

☀️ Try build successful - checks-actions
Build commit: efbb34e2a6d22a3aa83b7b108efed88c95141f59 (efbb34e2a6d22a3aa83b7b108efed88c95141f59)

@rust-timer
Copy link
Collaborator

Queued efbb34e2a6d22a3aa83b7b108efed88c95141f59 with parent 6421a49, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (efbb34e2a6d22a3aa83b7b108efed88c95141f59): comparison url.

Summary: This benchmark run shows 44 relevant improvements 🎉 to instruction counts.

  • Average relevant improvement: -0.5%
  • Largest improvement in instruction counts: -1.0% on full builds of projection-caching check

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Feb 15, 2022
@nagisa
Copy link
Member

nagisa commented Feb 15, 2022

@bors r+

@bors
Copy link
Contributor

bors commented Feb 15, 2022

📌 Commit ea71420 has been approved by nagisa

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 15, 2022
@bors
Copy link
Contributor

bors commented Feb 15, 2022

⌛ Testing commit ea71420 with merge 393fdc1...

@bors
Copy link
Contributor

bors commented Feb 16, 2022

☀️ Test successful - checks-actions
Approved by: nagisa
Pushing 393fdc1 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Feb 16, 2022
@bors bors merged commit 393fdc1 into rust-lang:master Feb 16, 2022
@rustbot rustbot added this to the 1.60.0 milestone Feb 16, 2022
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (393fdc1): comparison url.

Summary: This benchmark run did not return any relevant results. 103 results were found to be statistically significant but too small to be relevant.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

@tmiasko tmiasko deleted the inline branch February 16, 2022 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants