-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump compiler-builtins to 0.1.69 #93696
Conversation
(rust-highfive has picked a reviewer for you, use r? to override) |
@bors rollup=iffy |
Can you update this comment - https://github.com/rust-lang/rust/blob/master/Cargo.toml#L68 I'm worried that it seems like the comment suggests separate modules shouldn't be necessary, but maybe I am missing something. |
This comment still applies, it's just that codegen unit splitting only works at module boundaries so each function needs to be wrapped in its own |
That makes sense to me. It may be worth adding a flag to rustc which partitions without the module boundary grouping, FWIW, but seems like this solution works OK for now. @bors r+ rollup=never |
📌 Commit 59b2ee564093747c0b4de8036942fa8145750504 has been approved by |
⌛ Testing commit 59b2ee564093747c0b4de8036942fa8145750504 with merge 18f60772bab1f08de99ceb7409fc0f20c29a5d50... |
This comment has been minimized.
This comment has been minimized.
💔 Test failed - checks-actions |
59b2ee5
to
7b8f6ac
Compare
There was a typo in the inline assembly which caused the wrong function to be called. This is fixed in compiler-builtins 0.1.69. |
@bors r+ rollup=never |
📌 Commit 7b8f6ac has been approved by |
☀️ Test successful - checks-actions |
Finished benchmarking commit (01c4c41): comparison url. Summary: This benchmark run did not return any relevant results. If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression |
This includes rust-lang/compiler-builtins#452 which should fix some issues with duplicate symbol defintions of some intrinsics.