rustdoc-json: Add some tests for typealias item #93660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-rustdoc
rust-highfive
added
the
S-waiting-on-review
|
@rustbot modify labels: +A-rustdoc-json +T-rustdoc +A-testsuite |
rustbot
added
A-rustdoc-json
CraftSpider
reviewed
Feb 7, 2022
|
I was thinking about adding the ability to use |
aDotInTheVoid
force-pushed
the
rustdoc-type-tests
branch
from
7372c80 to
bf0e862
Compare
Long term I'm not sure if the correct answer is do stuff like this to make jsonPath more sustainable, or to move to something like deserializing the json to a Anyway, this is ready to be merged |
|
Hmm, that's an interesting idea I hadn't considered. The one downside is that it would probably require two files per test, but that may be worth it for just writing tests in Rust |
|
Anyways |
|
📌 Commit bf0e862 has been approved by |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Feb 11, 2022
…=CraftSpider rustdoc-json: Add some tests for typealias item r? `@CraftSpider` Improves rust-lang#81359 The test's arn't pretty, and I think eventually we need a better way of doing repeated tests on a deeply nested path, without repeating the way to get to that path `@rustbot` modify labels: +A-rustdoc-json +T-rustdoc +A-rustdoc +A-testsuite
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Feb 11, 2022
…=CraftSpider rustdoc-json: Add some tests for typealias item r? ``@CraftSpider`` Improves rust-lang#81359 The test's arn't pretty, and I think eventually we need a better way of doing repeated tests on a deeply nested path, without repeating the way to get to that path ``@rustbot`` modify labels: +A-rustdoc-json +T-rustdoc +A-rustdoc +A-testsuite
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 11, 2022
…askrgr Rollup of 10 pull requests Successful merges: - rust-lang#90955 (Rename `FilenameTooLong` to `InvalidFilename` and also use it for Windows' `ERROR_INVALID_NAME`) - rust-lang#91607 (Make `span_extend_to_prev_str()` more robust) - rust-lang#92895 (Remove some unused functionality) - rust-lang#93635 (Add missing platform-specific information on current_dir and set_current_dir) - rust-lang#93660 (rustdoc-json: Add some tests for typealias item) - rust-lang#93782 (Split `pauth` target feature) - rust-lang#93868 (Fix incorrect register conflict detection in asm!) - rust-lang#93888 (Implement `AsFd` for `&T` and `&mut T`.) - rust-lang#93909 (Fix typo: explicitely -> explicitly) - rust-lang#93910 (fix mention of moved function in `rustc_hir` docs) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @CraftSpider
Improves #81359
The test's arn't pretty, and I think eventually we need a better way of doing repeated tests on a deeply nested path,
without repeating the way to get to that path
@rustbot modify labels: +A-rustdoc-json +T-rustdoc +A-rustdoc +A-testsuite