Remove &mut from io::read_to_string signature
#92863
Merged
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camelid
added
T-libs-api
rust-highfive
added
the
S-waiting-on-review
4 tasks
|
I can't think of any downsides to this change, but of course let me know if you think of one :) |
|
Should I add a test for passing an |
`@m-ou-se` [realized][1] that because `Read` is implemented for `&mut impl Read`, there's no need to take `&mut` in `io::read_to_string`. Removing the `&mut` from the signature allows users to remove the `&mut` from their calls (and thus pass an owned reader) if they don't use the reader later. [1]: rust-lang#80218 (comment)
camelid
force-pushed
the
read_to_string-rm-mut
branch
from
2382470 to
aa0ce4a
Compare
|
@bors r+ Thanks! |
|
📌 Commit aa0ce4a has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 15, 2022
…askrgr Rollup of 8 pull requests Successful merges: - rust-lang#92747 (Simplification of BigNum::bit_length) - rust-lang#92767 (Use the new language identifier for Rust in the PDB debug format) - rust-lang#92775 (Inline std::os::unix::ffi::OsStringExt methods) - rust-lang#92863 (Remove `&mut` from `io::read_to_string` signature) - rust-lang#92865 (Ignore static lifetimes for GATs outlives lint) - rust-lang#92873 (Generate more precise generator names) - rust-lang#92879 (Add Sync bound to allocator parameter in vec::IntoIter) - rust-lang#92892 (Do not fail evaluation in const blocks) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@m-ou-serealized that becauseReadis implemented for&mut impl Read, there's no need to take&mutinio::read_to_string.Removing the
&mutfrom the signature allows users to remove the&mutfrom their calls (and thus pass an owned reader) if they don't use the
reader later.
r? @m-ou-se