Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some cleanups around check_argument_types #92360

Merged
merged 4 commits into from
Jan 6, 2022

Conversation

jackh726
Copy link
Member

Split out in ways from my rebase/continuation of #71827

Commits are mostly self-explanatory and these changes should be fairly straightforward

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Dec 28, 2021
@rust-highfive
Copy link
Collaborator

r? @davidtwco

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 28, 2021
@rust-log-analyzer

This comment has been minimized.

@davidtwco
Copy link
Member

Apologies for the delay in getting to this review.

@bors r+

@bors
Copy link
Contributor

bors commented Jan 5, 2022

📌 Commit bbb8bde has been approved by davidtwco

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 5, 2022
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jan 5, 2022
…dtwco

Some cleanups around check_argument_types

Split out in ways from my rebase/continuation of rust-lang#71827

Commits are mostly self-explanatory and these changes should be fairly straightforward
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jan 5, 2022
…dtwco

Some cleanups around check_argument_types

Split out in ways from my rebase/continuation of rust-lang#71827

Commits are mostly self-explanatory and these changes should be fairly straightforward
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 6, 2022
…askrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#92058 (Make Run button visible on hover)
 - rust-lang#92288 (Fix a pair of mistyped test cases in `std::net::ip`)
 - rust-lang#92349 (Fix rustdoc::private_doc_tests lint for public re-exported items)
 - rust-lang#92360 (Some cleanups around check_argument_types)
 - rust-lang#92389 (Regression test for borrowck ICE rust-lang#92015)
 - rust-lang#92404 (Fix font size for [src] links in headers)
 - rust-lang#92443 (Rustdoc: resolve associated traits for non-generic primitive types)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit fb87e7c into rust-lang:master Jan 6, 2022
@rustbot rustbot added this to the 1.59.0 milestone Jan 6, 2022
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Mar 7, 2022
…dtwco

Check extra function arg exprs even if the fn is not C-variadic

We should still call check_expr on the args that exceed the formal input ty count, so that we have expr types to emit during writeback.

Not sure where this regressed, but it wasn't due to the same root cause as rust-lang#94334 I think. I thought this might've regressed in rust-lang#92360, but I think that is in stable, ad the test I provided (which minimizes rust-lang#94599) passes on stable in playground. Maybe it regressed in rust-lang#93118.

Anywho, fixes rust-lang#94599.
@jackh726 jackh726 deleted the param-heuristics-1 branch March 12, 2022 18:26
@jackh726 jackh726 restored the param-heuristics-1 branch March 12, 2022 18:30
@jackh726 jackh726 deleted the param-heuristics-1 branch March 12, 2022 18:32
@jackh726 jackh726 restored the param-heuristics-1 branch March 12, 2022 18:42
@jackh726 jackh726 deleted the param-heuristics-1 branch March 12, 2022 18:43
@jackh726 jackh726 restored the param-heuristics-1 branch March 12, 2022 18:45
@jackh726 jackh726 deleted the param-heuristics-1 branch March 12, 2022 18:45
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 16, 2022
…euristics, r=estebank

Better method call error messages

Rebase/continuation of rust-lang#71827

~Based on rust-lang#92360~
~Based on rust-lang#93118~

There's a decent description in rust-lang#71827 that I won't copy here (for now at least)

In addition to rebasing, I've tried to restore most of the original suggestions for invalid arguments. Unfortunately, this does make some of the errors a bit verbose. To fix this will require a bit of refactoring to some of the generalized error suggestion functions, and I just don't have the time to go into it right now.

I think this is in a state that the error messages are overall better than before without a reduction in the suggestions given.

~I've tried to split out some of the easier and self-contained changes into separate commits (mostly in rust-lang#92360, but also one here). There might be more than can be done here, but again just lacking time.~

r? `@estebank` as the original reviewer of rust-lang#71827
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants