rustdoc: Remove `collect` call in `clean::Generics::print` #92269

vacuus · 2021-12-25T03:50:04Z

No description provided.

rust-highfive · 2021-12-25T03:50:07Z

r? @GuillaumeGomez

(rust-highfive has picked a reviewer for you, use r? to override)

vacuus · 2021-12-25T04:25:06Z

I finally realized that I just needed to install 'ninja', whatever that is, to get x.py fmt to work.

GuillaumeGomez · 2021-12-25T18:37:18Z

Thanks! Let's see the impact on perf.

@bors try @rust-timer queue

rust-timer · 2021-12-25T18:37:19Z

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

bors · 2021-12-25T18:37:25Z

⌛ Trying commit cad9c316bb4a0f9fb7c523679a1930e0145f6b85 with merge e2f3ea0a32b77ba4b3607d497bf7145def8412e1...

bors · 2021-12-25T20:11:30Z

☀️ Try build successful - checks-actions
Build commit: e2f3ea0a32b77ba4b3607d497bf7145def8412e1 (e2f3ea0a32b77ba4b3607d497bf7145def8412e1)

rust-timer · 2021-12-25T20:11:32Z

Queued e2f3ea0a32b77ba4b3607d497bf7145def8412e1 with parent c096176, future comparison URL.

rust-timer · 2021-12-26T00:35:16Z

Finished benchmarking commit (e2f3ea0a32b77ba4b3607d497bf7145def8412e1): comparison url.

Summary: This change led to small relevant improvements 🎉 in compiler performance.

Small improvement in instruction counts (up to -0.8% on incr-unchanged builds of externs)

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

src/librustdoc/html/format.rs

camelid · 2021-12-26T00:49:58Z

I finally realized that I just needed to install 'ninja', whatever that is, to get x.py fmt to work.

FWIW, you can just set ninja = false in your config.toml if you don't want to install ninja.

camelid · 2021-12-26T23:27:33Z

Thanks!

@bors r+ rollup=never

bors · 2021-12-26T23:27:35Z

📌 Commit bbbeefd has been approved by camelid

bors · 2021-12-27T02:54:34Z

⌛ Testing commit bbbeefd with merge d8b35fcacafbf65df3b61cf7cd12425e7841a7fd...

bors · 2021-12-27T07:09:34Z

💥 Test timed out

rust-log-analyzer · 2021-12-27T08:55:22Z

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

GuillaumeGomez · 2021-12-27T11:14:08Z

@bors retry

rust-log-analyzer · 2021-12-27T12:20:01Z

The job x86_64-gnu-aux failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

fatal: Could not parse object '91493fe47175076f330ce5fc518f0196c0476f56'.
From https://github.com/diesel-rs/diesel
 * branch            master     -> FETCH_HEAD
fatal: Could not parse object '91493fe47175076f330ce5fc518f0196c0476f56'.
fatal: unable to access 'https://github.com/diesel-rs/diesel/': gnutls_handshake() failed: Error in the pull function.
thread 'main' panicked at 'assertion failed: status.success()', src/tools/cargotest/main.rs:125:13
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/cargotest" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools-bin/cargo" "/checkout/obj/build/ct"
expected success, got: exit status: 101
expected success, got: exit status: 101


Build completed unsuccessfully in 0:25:27
make: *** [check-aux] Error 1
Makefile:44: recipe for target 'check-aux' failed

GuillaumeGomez · 2021-12-27T12:34:53Z

@bors retry

bors · 2021-12-27T12:58:10Z

⌛ Testing commit bbbeefd with merge b4ceb6f80c17c1c27bedaa8e29ac55656d4ec759...

bors · 2021-12-27T13:05:06Z

💔 Test failed - checks-actions

rust-log-analyzer · 2021-12-27T13:55:56Z

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

ehuss · 2021-12-27T17:08:35Z

@bors retry

network error

bors · 2021-12-28T11:38:04Z

⌛ Testing commit bbbeefd with merge 9229b4302a6b359fddef449929b2dc9d15c0bae1...

rust-log-analyzer · 2021-12-28T12:22:03Z

The job x86_64-msvc-2 failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

9 note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.
10 


The actual run.stderr differed from the expected run.stderr.
Actual run.stderr saved to D:\a\rust\rust\build\x86_64-pc-windows-msvc\test\ui\panics\panic-short-backtrace-windows-x86_64\panic-short-backtrace-windows-x86_64.run.stderr
error: 1 errors occurred comparing run output.
status: exit code: 101
status: exit code: 101
command: PATH="D:\a\rust\rust\build\x86_64-pc-windows-msvc\stage2\lib\rustlib\x86_64-pc-windows-msvc\lib;C:\Program Files (x86)\Windows Kits\10\bin\x64;C:\Program Files (x86)\Windows Kits\10\bin\10.0.22000.0\x64;C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Tools\MSVC\14.29.30133\bin\HostX64\x64;C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Tools\MSVC\14.29.30133\bin\HostX64\x64;D:\a\rust\rust\build\x86_64-pc-windows-msvc\stage0-bootstrap-tools\x86_64-pc-windows-msvc\release\deps;D:\a\rust\rust\build\x86_64-pc-windows-msvc\stage0\bin;D:\a\rust\rust\ninja;D:\a\rust\rust\msys2\mingw64\bin;C:\hostedtoolcache\windows\Python\3.10.1\x64\Scripts;C:\hostedtoolcache\windows\Python\3.10.1\x64;C:\msys64\usr\bin;D:\a\rust\rust\sccache;C:\Program Files\MongoDB\Server\5.0\bin;C:\aliyun-cli;C:\vcpkg;C:\cf-cli;C:\Program Files (x86)\NSIS;C:\tools\zstd;C:\Program Files\Mercurial;C:\hostedtoolcache\windows\stack\2.7.3\x64;C:\cabal\bin;C:\ghcup\bin;C:\tools\ghc-9.2.1\bin;C:\Program Files\dotnet;C:\mysql\bin;C:\Program Files\R\R-4.1.2\bin\x64;C:\SeleniumWebDrivers\GeckoDriver;C:\Program Files (x86)\sbt\bin;C:\Program Files (x86)\GitHub CLI;C:\Program Files\Git\bin;C:\Program Files (x86)\pipx_bin;C:\hostedtoolcache\windows\go\1.15.15\x64\bin;C:\hostedtoolcache\windows\Python\3.7.9\x64\Scripts;C:\hostedtoolcache\windows\Python\3.7.9\x64;C:\hostedtoolcache\windows\Ruby\2.5.9\x64\bin;C:\tools\kotlinc\bin;C:\hostedtoolcache\windows\Java_Temurin-Hotspot_jdk\8.0.312-7\x64\bin;C:\npm\prefix;C:\Program Files (x86)\Microsoft SDKs\Azure\CLI2\wbin;C:\ProgramData\kind;C:\Program Files\Eclipse Foundation\jdk-8.0.302.8-hotspot\bin;C:\Windows\system32;C:\Windows;C:\Windows\System32\Wbem;C:\Windows\System32\WindowsPowerShell\v1.0;C:\Windows\System32\OpenSSH;C:\ProgramData\Chocolatey\bin;C:\Program Files\Docker;C:\Program Files\PowerShell\7;C:\Program Files\Microsoft\Web Platform Installer;C:\Program Files\dotnet;C:\Program Files\Microsoft SQL Server\130\Tools\Binn;C:\Program Files\Microsoft SQL Server\Client SDK\ODBC\170\Tools\Binn;C:\Program Files (x86)\Windows Kits\10\Windows Performance Toolkit;C:\Program Files (x86)\Microsoft SQL Server\110\DTS\Binn;C:\Program Files (x86)\Microsoft SQL Server\120\DTS\Binn;C:\Program Files (x86)\Microsoft SQL Server\130\DTS\Binn;C:\Program Files (x86)\Microsoft SQL Server\140\DTS\Binn;C:\Program Files (x86)\Microsoft SQL Server\150\DTS\Binn;C:\Program Files\nodejs;C:\Program Files\OpenSSL\bin;C:\Strawberry\c\bin;C:\Strawberry\perl\site\bin;C:\Strawberry\perl\bin;C:\ProgramData\chocolatey\lib\pulumi\tools\Pulumi\bin;C:\Program Files\TortoiseSVN\bin;C:\Program Files\CMake\bin;C:\ProgramData\chocolatey\lib\maven\apache-maven-3.8.4\bin;C:\Program Files\Microsoft Service Fabric\bin\Fabric\Fabric.Code;C:\Program Files\Microsoft SDKs\Service Fabric\Tools\ServiceFabricLocalClusterManager;C:\Program Files\Git\cmd;C:\Program Files\Git\mingw64\bin;C:\Program Files\Git\usr\bin;C:\tools\php;C:\Program Files (x86)\sbt\bin;C:\SeleniumWebDrivers\ChromeDriver;C:\SeleniumWebDrivers\EdgeDriver;C:\Program Files\Amazon\AWSCLIV2;C:\Program Files\Amazon\SessionManagerPlugin\bin;C:\Program Files\Amazon\AWSSAMCLI\bin;C:\Program Files (x86)\Google\Cloud SDK\google-cloud-sdk\bin;C:\Program Files (x86)\Microsoft BizTalk Server;C:\Program Files\LLVM\bin;C:\Users\runneradmin\.dotnet\tools;C:\Users\runneradmin\.cargo\bin;C:\Users\runneradmin\AppData\Local\Microsoft\WindowsApps" "D:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\test\\ui\\panics\\panic-short-backtrace-windows-x86_64\\a.exe"
------------------------------------------

------------------------------------------
stderr:
stderr:
------------------------------------------
thread 'main' panicked at 'd was called', D:\a\rust\rust\src/test\ui\panics\panic-short-backtrace-windows-x86_64.rs:48:5
   0: std::panicking::begin_panic
   1: d
   2: c
   3: b
---

Some tests failed in compiletest suite=ui mode=ui host=x86_64-pc-windows-msvc target=x86_64-pc-windows-msvc


command did not execute successfully: "D:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage0-tools-bin\\compiletest.exe" "--compile-lib-path" "D:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage2\\bin" "--run-lib-path" "D:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage2\\lib\\rustlib\\x86_64-pc-windows-msvc\\lib" "--rustc-path" "D:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage2\\bin\\rustc.exe" "--src-base" "D:\\a\\rust\\rust\\src/test\\ui" "--build-base" "D:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\test\\ui" "--stage-id" "stage2-x86_64-pc-windows-msvc" "--suite" "ui" "--mode" "ui" "--target" "x86_64-pc-windows-msvc" "--host" "x86_64-pc-windows-msvc" "--llvm-filecheck" "D:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\llvm\\build\\bin\\FileCheck.exe" "--nodejs" "C:\\Program Files\\nodejs\\node" "--npm" "C:\\Program Files\\nodejs\\npm" "--host-rustcflags" "-Crpath -O -Cdebuginfo=0  -Lnative=D:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\native\\rust-test-helpers" "--target-rustcflags" "-Crpath -O -Cdebuginfo=0  -Lnative=D:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\native\\rust-test-helpers" "--docck-python" "C:\\hostedtoolcache\\windows\\Python\\3.10.1\\x64\\python3.exe" "--lldb-python" "C:\\hostedtoolcache\\windows\\Python\\3.10.1\\x64\\python3.exe" "--gdb" "C:\\msys64\\usr\\bin\\gdb" "--llvm-version" "13.0.0-rust-1.59.0-nightly" "--llvm-components" "aarch64 aarch64asmparser aarch64codegen aarch64desc aarch64disassembler aarch64info aarch64utils aggressiveinstcombine all all-targets analysis arm armasmparser armcodegen armdesc armdisassembler arminfo armutils asmparser asmprinter avr avrasmparser avrcodegen avrdesc avrdisassembler avrinfo binaryformat bitreader bitstreamreader bitwriter bpf bpfasmparser bpfcodegen bpfdesc bpfdisassembler bpfinfo cfguard codegen core coroutines coverage debuginfocodeview debuginfodwarf debuginfogsym debuginfomsf debuginfopdb demangle dlltooldriver dwarflinker dwp engine executionengine extensions filecheck frontendopenacc frontendopenmp fuzzmutate globalisel hexagon hexagonasmparser hexagoncodegen hexagondesc hexagondisassembler hexagoninfo instcombine instrumentation interfacestub interpreter ipo irreader jitlink libdriver lineeditor linker lto m68k m68kasmparser m68kcodegen m68kdesc m68kdisassembler m68kinfo mc mca mcdisassembler mcjit mcparser mips mipsasmparser mipscodegen mipsdesc mipsdisassembler mipsinfo mirparser msp430 msp430asmparser msp430codegen msp430desc msp430disassembler msp430info native nativecodegen nvptx nvptxcodegen nvptxdesc nvptxinfo objcarcopts object objectyaml option orcjit orcshared orctargetprocess passes powerpc powerpcasmparser powerpccodegen powerpcdesc powerpcdisassembler powerpcinfo profiledata remarks riscv riscvasmparser riscvcodegen riscvdesc riscvdisassembler riscvinfo runtimedyld scalaropts selectiondag sparc sparcasmparser sparccodegen sparcdesc sparcdisassembler sparcinfo support symbolize systemz systemzasmparser systemzcodegen systemzdesc systemzdisassembler systemzinfo tablegen target textapi transformutils vectorize webassembly webassemblyasmparser webassemblycodegen webassemblydesc webassemblydisassembler webassemblyinfo webassemblyutils windowsmanifest x86 x86asmparser x86codegen x86desc x86disassembler x86info xray" "--cc" "" "--cxx" "" "--cflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--channel" "nightly" "--color" "always"


Build completed unsuccessfully in 0:40:01
Build completed unsuccessfully in 0:40:01
make: *** [Makefile:74: ci-subset-2] Error 1

bors · 2021-12-28T12:22:41Z

💔 Test failed - checks-actions

ehuss · 2021-12-28T15:09:03Z

@bors retry

#92000

bors · 2021-12-28T23:38:57Z

⌛ Testing commit bbbeefd with merge 7ae5508...

bors · 2021-12-29T02:49:29Z

☀️ Test successful - checks-actions
Approved by: camelid
Pushing 7ae5508 to master...

rust-timer · 2021-12-29T04:19:14Z

Finished benchmarking commit (7ae5508): comparison url.

Summary: This benchmark run did not return any relevant changes.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

rustbot added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Dec 25, 2021

rust-highfive assigned GuillaumeGomez Dec 25, 2021

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 25, 2021

This comment has been minimized.

Sign in to view

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Dec 25, 2021

rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Dec 26, 2021

camelid reviewed Dec 26, 2021

View reviewed changes

src/librustdoc/html/format.rs Outdated Show resolved Hide resolved

Remove unneeded call to collect

bbbeefd

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 26, 2021

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 27, 2021

bors added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 27, 2021

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 27, 2021

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 27, 2021

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 27, 2021

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 28, 2021

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 28, 2021

bors added the merged-by-bors This PR was explicitly merged by bors. label Dec 29, 2021

bors merged commit 7ae5508 into rust-lang:master Dec 29, 2021

rustbot added this to the 1.59.0 milestone Dec 29, 2021

vacuus deleted the clean-generics-print branch April 8, 2022 21:01

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

rustdoc: Remove `collect` call in `clean::Generics::print` #92269

rustdoc: Remove `collect` call in `clean::Generics::print` #92269

vacuus commented Dec 25, 2021

rust-highfive commented Dec 25, 2021

This comment has been minimized.

This comment has been minimized.

vacuus commented Dec 25, 2021

GuillaumeGomez commented Dec 25, 2021

rust-timer commented Dec 25, 2021

bors commented Dec 25, 2021

bors commented Dec 25, 2021

rust-timer commented Dec 25, 2021

rust-timer commented Dec 26, 2021

camelid commented Dec 26, 2021

camelid commented Dec 26, 2021

bors commented Dec 26, 2021

bors commented Dec 27, 2021

bors commented Dec 27, 2021

rust-log-analyzer commented Dec 27, 2021

GuillaumeGomez commented Dec 27, 2021

rust-log-analyzer commented Dec 27, 2021

GuillaumeGomez commented Dec 27, 2021

bors commented Dec 27, 2021

bors commented Dec 27, 2021

rust-log-analyzer commented Dec 27, 2021

ehuss commented Dec 27, 2021

bors commented Dec 28, 2021

rust-log-analyzer commented Dec 28, 2021

bors commented Dec 28, 2021

ehuss commented Dec 28, 2021

bors commented Dec 28, 2021

bors commented Dec 29, 2021

rust-timer commented Dec 29, 2021

rustdoc: Remove collect call in clean::Generics::print #92269

rustdoc: Remove collect call in clean::Generics::print #92269

Conversation

vacuus commented Dec 25, 2021

rust-highfive commented Dec 25, 2021

This comment has been minimized.

This comment has been minimized.

vacuus commented Dec 25, 2021

GuillaumeGomez commented Dec 25, 2021

rust-timer commented Dec 25, 2021

bors commented Dec 25, 2021

bors commented Dec 25, 2021

rust-timer commented Dec 25, 2021

rust-timer commented Dec 26, 2021

camelid commented Dec 26, 2021

camelid commented Dec 26, 2021

bors commented Dec 26, 2021

bors commented Dec 27, 2021

bors commented Dec 27, 2021

rust-log-analyzer commented Dec 27, 2021

GuillaumeGomez commented Dec 27, 2021

rust-log-analyzer commented Dec 27, 2021

GuillaumeGomez commented Dec 27, 2021

bors commented Dec 27, 2021

bors commented Dec 27, 2021

rust-log-analyzer commented Dec 27, 2021

ehuss commented Dec 27, 2021

bors commented Dec 28, 2021

rust-log-analyzer commented Dec 28, 2021

bors commented Dec 28, 2021

ehuss commented Dec 28, 2021

bors commented Dec 28, 2021

bors commented Dec 29, 2021

rust-timer commented Dec 29, 2021

rustdoc: Remove `collect` call in `clean::Generics::print` #92269

rustdoc: Remove `collect` call in `clean::Generics::print` #92269