Remove 'speculative evaluation' of predicates #92041

Aaron1011 · 2021-12-17T15:28:37Z

Performing 'speculative evaluation' introduces caching bugs that
cannot be fixed without invasive changes to projection.

Hopefully, we can win back most of the performance lost by
re-adding 'cache completion'

Fixes #90662

rust-highfive · 2021-12-17T15:28:40Z

r? @davidtwco

(rust-highfive has picked a reviewer for you, use r? to override)

Aaron1011 · 2021-12-17T15:28:49Z

@bors try @rust-timer queue

rust-timer · 2021-12-17T15:28:50Z

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

bors · 2021-12-17T15:28:56Z

⌛ Trying commit 9f4099f29717f0db050fda4d36feef47a06c2b43 with merge d2e7c7d2c1bbc2cb90db373e42dba2653351604a...

bors · 2021-12-17T17:07:13Z

☀️ Try build successful - checks-actions
Build commit: d2e7c7d2c1bbc2cb90db373e42dba2653351604a (d2e7c7d2c1bbc2cb90db373e42dba2653351604a)

rust-timer · 2021-12-17T17:07:15Z

Queued d2e7c7d2c1bbc2cb90db373e42dba2653351604a with parent 2595d03, future comparison URL.

Mark-Simulacrum · 2021-12-17T18:24:17Z

Note that due to merging rust-lang/rustc-perf#1123, these runs may look quite bad -- once we get another master commit landed + benchmarked, re-running perf should make any noise there go away. It shouldn't affect non-incremental results, though, of course.

(Leaving this comment on all pending perf run PRs).

rust-timer · 2021-12-17T19:56:43Z

Finished benchmarking commit (d2e7c7d2c1bbc2cb90db373e42dba2653351604a): comparison url.

Summary: This change led to very large relevant mixed results 🤷 in compiler performance.

Large improvement in instruction counts (up to -3.5% on full builds of regression-31157)
Very large regression in instruction counts (up to 133.3% on incr-unchanged builds of ctfe-stress-4)

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf +perf-regression

Aaron1011 · 2021-12-17T19:59:42Z

Ignoring the spurious incremental runs, this only causes a few perf regressions (up to 4.53% on deeply-nested). Since this fixes a spurious compilation error, I think we should merge it, and try to recover the performance elsewhere.

jackh726 · 2021-12-17T21:21:46Z

Agreed

@bors r+

bors · 2021-12-17T21:21:48Z

📌 Commit 9f4099f29717f0db050fda4d36feef47a06c2b43 has been approved by jackh726

Performing 'speculative evaluation' introduces caching bugs that cannot be fixed without invasive changes to projection. Hopefully, we can win back most of the performance lost by re-adding 'cache completion' Fixes rust-lang#90662

Aaron1011 · 2021-12-17T22:01:29Z

Added regression test for the underlying issue.

@bors r=jackh726

bors · 2021-12-17T22:01:30Z

📌 Commit eee09ec has been approved by jackh726

jyn514 · 2021-12-18T01:10:06Z

https://rust-lang.zulipchat.com/#narrow/stream/233931-t-compiler.2Fmajor-changes/topic/Make.20.60TypeFolder.3A.3Afold_*.60.20return.20.60Result.60.20compiler-team.23432/near/239243869 mentions that overflow errors need to be treated differently because of speculative evaluation - can it be combined with other errors now that speculative evaluation is being removed?

jackh726 · 2021-12-18T01:54:42Z

This is only one small instance of speculative evaluation.

bors · 2021-12-19T16:30:55Z

⌛ Testing commit eee09ec with merge e33258f4a0a3c76852849b8fd3911f60a1dbc762...

rust-log-analyzer · 2021-12-19T17:13:26Z

The job x86_64-msvc-2 failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

9 note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.
10 


The actual run.stderr differed from the expected run.stderr.
Actual run.stderr saved to D:\a\rust\rust\build\x86_64-pc-windows-msvc\test\ui\panics\panic-short-backtrace-windows-x86_64\panic-short-backtrace-windows-x86_64.run.stderr
error: 1 errors occurred comparing run output.
status: exit code: 101
status: exit code: 101
command: PATH="D:\a\rust\rust\build\x86_64-pc-windows-msvc\stage2\lib\rustlib\x86_64-pc-windows-msvc\lib;C:\Program Files (x86)\Windows Kits\10\bin\x64;C:\Program Files (x86)\Windows Kits\10\bin\10.0.22000.0\x64;C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Tools\MSVC\14.29.30133\bin\HostX64\x64;C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Tools\MSVC\14.29.30133\bin\HostX64\x64;D:\a\rust\rust\build\x86_64-pc-windows-msvc\stage0-bootstrap-tools\x86_64-pc-windows-msvc\release\deps;D:\a\rust\rust\build\x86_64-pc-windows-msvc\stage0\bin;D:\a\rust\rust\ninja;D:\a\rust\rust\msys2\mingw64\bin;C:\hostedtoolcache\windows\Python\3.10.0\x64\Scripts;C:\hostedtoolcache\windows\Python\3.10.0\x64;C:\msys64\usr\bin;D:\a\rust\rust\sccache;C:\Program Files\MongoDB\Server\5.0\bin;C:\aliyun-cli;C:\vcpkg;C:\cf-cli;C:\Program Files (x86)\NSIS;C:\tools\zstd;C:\Program Files\Mercurial;C:\hostedtoolcache\windows\stack\2.7.3\x64;C:\cabal\bin;C:\ghcup\bin;C:\tools\ghc-9.2.1\bin;C:\Program Files\dotnet;C:\mysql\bin;C:\Program Files\R\R-4.1.2\bin\x64;C:\SeleniumWebDrivers\GeckoDriver;C:\Program Files (x86)\sbt\bin;C:\Rust\.cargo\bin;C:\Program Files (x86)\GitHub CLI;C:\Program Files\Git\bin;C:\Program Files (x86)\pipx_bin;C:\hostedtoolcache\windows\go\1.15.15\x64\bin;C:\hostedtoolcache\windows\Python\3.7.9\x64\Scripts;C:\hostedtoolcache\windows\Python\3.7.9\x64;C:\hostedtoolcache\windows\Ruby\2.5.9\x64\bin;C:\tools\kotlinc\bin;C:\hostedtoolcache\windows\Java_Temurin-Hotspot_jdk\8.0.312-7\x64\bin;C:\npm\prefix;C:\Program Files (x86)\Microsoft SDKs\Azure\CLI2\wbin;C:\ProgramData\kind;C:\Program Files\Eclipse Foundation\jdk-8.0.302.8-hotspot\bin;C:\Windows\system32;C:\Windows;C:\Windows\System32\Wbem;C:\Windows\System32\WindowsPowerShell\v1.0;C:\Windows\System32\OpenSSH;C:\ProgramData\Chocolatey\bin;C:\Program Files\Docker;C:\Program Files\PowerShell\7;C:\Program Files\Microsoft\Web Platform Installer;C:\Program Files\dotnet;C:\Program Files\Microsoft SQL Server\130\Tools\Binn;C:\Program Files\Microsoft SQL Server\Client SDK\ODBC\170\Tools\Binn;C:\Program Files (x86)\Windows Kits\10\Windows Performance Toolkit;C:\Program Files (x86)\Microsoft SQL Server\110\DTS\Binn;C:\Program Files (x86)\Microsoft SQL Server\120\DTS\Binn;C:\Program Files (x86)\Microsoft SQL Server\130\DTS\Binn;C:\Program Files (x86)\Microsoft SQL Server\140\DTS\Binn;C:\Program Files (x86)\Microsoft SQL Server\150\DTS\Binn;C:\Program Files\nodejs;C:\Program Files\OpenSSL\bin;C:\Strawberry\c\bin;C:\Strawberry\perl\site\bin;C:\Strawberry\perl\bin;C:\ProgramData\chocolatey\lib\pulumi\tools\Pulumi\bin;C:\Program Files\TortoiseSVN\bin;C:\Program Files\CMake\bin;C:\ProgramData\chocolatey\lib\maven\apache-maven-3.8.4\bin;C:\Program Files\Microsoft Service Fabric\bin\Fabric\Fabric.Code;C:\Program Files\Microsoft SDKs\Service Fabric\Tools\ServiceFabricLocalClusterManager;C:\Program Files\Git\cmd;C:\Program Files\Git\mingw64\bin;C:\Program Files\Git\usr\bin;C:\tools\php;C:\Program Files (x86)\sbt\bin;C:\SeleniumWebDrivers\ChromeDriver;C:\SeleniumWebDrivers\EdgeDriver;C:\Program Files\Amazon\AWSCLIV2;C:\Program Files\Amazon\SessionManagerPlugin\bin;C:\Program Files\Amazon\AWSSAMCLI\bin;C:\Program Files (x86)\Google\Cloud SDK\google-cloud-sdk\bin;C:\Program Files (x86)\Microsoft BizTalk Server;C:\Program Files\LLVM\bin;C:\Users\runneradmin\.dotnet\tools;C:\Users\runneradmin\AppData\Local\Microsoft\WindowsApps" "D:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\test\\ui\\panics\\panic-short-backtrace-windows-x86_64\\a.exe"
------------------------------------------

------------------------------------------
stderr:
stderr:
------------------------------------------
thread 'main' panicked at 'd was called', D:\a\rust\rust\src/test\ui\panics\panic-short-backtrace-windows-x86_64.rs:48:5
   0: std::panicking::begin_panic
   1: d
   2: c
   3: b
---

Some tests failed in compiletest suite=ui mode=ui host=x86_64-pc-windows-msvc target=x86_64-pc-windows-msvc


command did not execute successfully: "D:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage0-tools-bin\\compiletest.exe" "--compile-lib-path" "D:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage2\\bin" "--run-lib-path" "D:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage2\\lib\\rustlib\\x86_64-pc-windows-msvc\\lib" "--rustc-path" "D:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage2\\bin\\rustc.exe" "--src-base" "D:\\a\\rust\\rust\\src/test\\ui" "--build-base" "D:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\test\\ui" "--stage-id" "stage2-x86_64-pc-windows-msvc" "--suite" "ui" "--mode" "ui" "--target" "x86_64-pc-windows-msvc" "--host" "x86_64-pc-windows-msvc" "--llvm-filecheck" "D:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\llvm\\build\\bin\\FileCheck.exe" "--nodejs" "C:\\Program Files\\nodejs\\node" "--npm" "C:\\Program Files\\nodejs\\npm" "--host-rustcflags" "-Crpath -O -Cdebuginfo=0  -Lnative=D:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\native\\rust-test-helpers" "--target-rustcflags" "-Crpath -O -Cdebuginfo=0  -Lnative=D:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\native\\rust-test-helpers" "--docck-python" "C:\\hostedtoolcache\\windows\\Python\\3.10.0\\x64\\python3.exe" "--lldb-python" "C:\\hostedtoolcache\\windows\\Python\\3.10.0\\x64\\python3.exe" "--gdb" "C:\\msys64\\usr\\bin\\gdb" "--llvm-version" "13.0.0-rust-1.59.0-nightly" "--llvm-components" "aarch64 aarch64asmparser aarch64codegen aarch64desc aarch64disassembler aarch64info aarch64utils aggressiveinstcombine all all-targets analysis arm armasmparser armcodegen armdesc armdisassembler arminfo armutils asmparser asmprinter avr avrasmparser avrcodegen avrdesc avrdisassembler avrinfo binaryformat bitreader bitstreamreader bitwriter bpf bpfasmparser bpfcodegen bpfdesc bpfdisassembler bpfinfo cfguard codegen core coroutines coverage debuginfocodeview debuginfodwarf debuginfogsym debuginfomsf debuginfopdb demangle dlltooldriver dwarflinker dwp engine executionengine extensions filecheck frontendopenacc frontendopenmp fuzzmutate globalisel hexagon hexagonasmparser hexagoncodegen hexagondesc hexagondisassembler hexagoninfo instcombine instrumentation interfacestub interpreter ipo irreader jitlink libdriver lineeditor linker lto m68k m68kasmparser m68kcodegen m68kdesc m68kdisassembler m68kinfo mc mca mcdisassembler mcjit mcparser mips mipsasmparser mipscodegen mipsdesc mipsdisassembler mipsinfo mirparser msp430 msp430asmparser msp430codegen msp430desc msp430disassembler msp430info native nativecodegen nvptx nvptxcodegen nvptxdesc nvptxinfo objcarcopts object objectyaml option orcjit orcshared orctargetprocess passes powerpc powerpcasmparser powerpccodegen powerpcdesc powerpcdisassembler powerpcinfo profiledata remarks riscv riscvasmparser riscvcodegen riscvdesc riscvdisassembler riscvinfo runtimedyld scalaropts selectiondag sparc sparcasmparser sparccodegen sparcdesc sparcdisassembler sparcinfo support symbolize systemz systemzasmparser systemzcodegen systemzdesc systemzdisassembler systemzinfo tablegen target textapi transformutils vectorize webassembly webassemblyasmparser webassemblycodegen webassemblydesc webassemblydisassembler webassemblyinfo webassemblyutils windowsmanifest x86 x86asmparser x86codegen x86desc x86disassembler x86info xray" "--cc" "" "--cxx" "" "--cflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--channel" "nightly" "--color" "always"


Build completed unsuccessfully in 0:37:52
Build completed unsuccessfully in 0:37:52
make: *** [Makefile:74: ci-subset-2] Error 1

bors · 2021-12-19T17:14:08Z

💔 Test failed - checks-actions

matthiaskrgr · 2021-12-19T17:18:19Z

@bors retry #92000

bors · 2021-12-19T20:23:52Z

⌛ Testing commit eee09ec with merge 24a170b831fafa261234eb6624b0fbba02429b11...

bors · 2021-12-20T00:38:52Z

💥 Test timed out

matthiaskrgr · 2021-12-20T00:44:35Z

@bors retry x86_64-apple timeout

rust-log-analyzer · 2021-12-20T00:48:39Z

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

bors · 2021-12-20T03:35:08Z

⌛ Testing commit eee09ec with merge 110d3ea03635a465aca938e161bd0aba00923a54...

rust-log-analyzer · 2021-12-20T04:20:26Z

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

bors · 2021-12-20T04:21:06Z

💔 Test failed - checks-actions

jackh726 · 2021-12-20T04:58:19Z

@bors retry

bors · 2021-12-20T07:30:19Z

⌛ Testing commit eee09ec with merge 60f3bd7...

bors · 2021-12-20T10:35:42Z

☀️ Test successful - checks-actions
Approved by: jackh726
Pushing 60f3bd7 to master...

rust-timer · 2021-12-20T12:06:37Z

Finished benchmarking commit (60f3bd7): comparison url.

Summary: This change led to very large relevant mixed results 🤷 in compiler performance.

Very large improvement in instruction counts (up to -5.8% on incr-unchanged builds of regression-31157)
Very large regression in instruction counts (up to 8.8% on incr-unchanged builds of deeply-nested)

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please open an issue or create a new PR that fixes the regressions, add a comment linking to the newly created issue or PR, and then add the perf-regression-triaged label to this PR.

@rustbot label: +perf-regression

rust-highfive assigned davidtwco Dec 17, 2021

rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Dec 17, 2021

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 17, 2021

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Dec 17, 2021

rustbot added perf-regression Performance regression. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Dec 17, 2021

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 17, 2021

Remove 'speculative evaluation' of predicates

eee09ec

Performing 'speculative evaluation' introduces caching bugs that cannot be fixed without invasive changes to projection. Hopefully, we can win back most of the performance lost by re-adding 'cache completion' Fixes rust-lang#90662

Aaron1011 force-pushed the remove-speculative-evaluation branch from 9f4099f to eee09ec Compare December 17, 2021 22:00

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 19, 2021

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 19, 2021

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 20, 2021

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 20, 2021

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 20, 2021

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 20, 2021

bors added the merged-by-bors This PR was explicitly merged by bors. label Dec 20, 2021

bors merged commit 60f3bd7 into rust-lang:master Dec 20, 2021

rustbot added this to the 1.59.0 milestone Dec 20, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove 'speculative evaluation' of predicates #92041

Remove 'speculative evaluation' of predicates #92041

Aaron1011 commented Dec 17, 2021 •

edited

Loading

rust-highfive commented Dec 17, 2021

Aaron1011 commented Dec 17, 2021

rust-timer commented Dec 17, 2021

bors commented Dec 17, 2021

bors commented Dec 17, 2021

rust-timer commented Dec 17, 2021

Mark-Simulacrum commented Dec 17, 2021

rust-timer commented Dec 17, 2021

Aaron1011 commented Dec 17, 2021

jackh726 commented Dec 17, 2021

bors commented Dec 17, 2021

Aaron1011 commented Dec 17, 2021

bors commented Dec 17, 2021

jyn514 commented Dec 18, 2021 •

edited

Loading

jackh726 commented Dec 18, 2021

bors commented Dec 19, 2021

rust-log-analyzer commented Dec 19, 2021

bors commented Dec 19, 2021

matthiaskrgr commented Dec 19, 2021

bors commented Dec 19, 2021

bors commented Dec 20, 2021

matthiaskrgr commented Dec 20, 2021

rust-log-analyzer commented Dec 20, 2021

bors commented Dec 20, 2021

rust-log-analyzer commented Dec 20, 2021

bors commented Dec 20, 2021

jackh726 commented Dec 20, 2021

bors commented Dec 20, 2021

bors commented Dec 20, 2021

rust-timer commented Dec 20, 2021

Remove 'speculative evaluation' of predicates #92041

Remove 'speculative evaluation' of predicates #92041

Conversation

Aaron1011 commented Dec 17, 2021 • edited Loading

rust-highfive commented Dec 17, 2021

Aaron1011 commented Dec 17, 2021

rust-timer commented Dec 17, 2021

bors commented Dec 17, 2021

bors commented Dec 17, 2021

rust-timer commented Dec 17, 2021

Mark-Simulacrum commented Dec 17, 2021

rust-timer commented Dec 17, 2021

Aaron1011 commented Dec 17, 2021

jackh726 commented Dec 17, 2021

bors commented Dec 17, 2021

Aaron1011 commented Dec 17, 2021

bors commented Dec 17, 2021

jyn514 commented Dec 18, 2021 • edited Loading

jackh726 commented Dec 18, 2021

bors commented Dec 19, 2021

rust-log-analyzer commented Dec 19, 2021

bors commented Dec 19, 2021

matthiaskrgr commented Dec 19, 2021

bors commented Dec 19, 2021

bors commented Dec 20, 2021

matthiaskrgr commented Dec 20, 2021

rust-log-analyzer commented Dec 20, 2021

bors commented Dec 20, 2021

rust-log-analyzer commented Dec 20, 2021

bors commented Dec 20, 2021

jackh726 commented Dec 20, 2021

bors commented Dec 20, 2021

bors commented Dec 20, 2021

rust-timer commented Dec 20, 2021

Aaron1011 commented Dec 17, 2021 •

edited

Loading

jyn514 commented Dec 18, 2021 •

edited

Loading