Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store hir_id_to_def_id in OwnerNodes. #91112

Closed
wants to merge 2 commits into from

Conversation

cjgillot
Copy link
Contributor

@cjgillot cjgillot commented Nov 21, 2021

Half step in #89278.

The HirId -> LocalDefId is currently untracked by incr. comp.
Although it has not been identified as causing incr. comp. bugs, there is no insurance against such future bugs.

This PR aims to restructure those maps consistently with the HIR itself.

@cjgillot
Copy link
Contributor Author

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Nov 21, 2021
@bors
Copy link
Contributor

bors commented Nov 21, 2021

⌛ Trying commit a8771c6800377125b7fc5df00b60563bb529c198 with merge beaf918adcf84a91683827db6b76fd8f00681595...

@rust-log-analyzer

This comment has been minimized.

@bors
Copy link
Contributor

bors commented Nov 21, 2021

☀️ Try build successful - checks-actions
Build commit: beaf918adcf84a91683827db6b76fd8f00681595 (beaf918adcf84a91683827db6b76fd8f00681595)

@rust-timer
Copy link
Collaborator

Queued beaf918adcf84a91683827db6b76fd8f00681595 with parent 49d4232, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (beaf918adcf84a91683827db6b76fd8f00681595): comparison url.

Summary: This change led to large relevant regressions 😿 in compiler performance.

  • Large regression in instruction counts (up to 2.9% on incr-unchanged builds of match-stress-enum)

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf +perf-regression

@rustbot rustbot added perf-regression Performance regression. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Nov 22, 2021
@camelid camelid added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Nov 25, 2021
@cjgillot cjgillot changed the title Store hir_id_to_def_id in OwnerInfo. Store hir_id_to_def_id in OwnerNodes. Dec 5, 2021
@cjgillot
Copy link
Contributor Author

cjgillot commented Dec 5, 2021

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Dec 5, 2021
@bors
Copy link
Contributor

bors commented Dec 5, 2021

⌛ Trying commit 1d9023ef83a39165a1d255517bf75025599b2730 with merge 89f519c544b7437eda1f1deb79c9784bc4b60f1a...

@bors
Copy link
Contributor

bors commented Dec 5, 2021

☀️ Try build successful - checks-actions
Build commit: 89f519c544b7437eda1f1deb79c9784bc4b60f1a (89f519c544b7437eda1f1deb79c9784bc4b60f1a)

@rust-timer
Copy link
Collaborator

Queued 89f519c544b7437eda1f1deb79c9784bc4b60f1a with parent cafc458, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (89f519c544b7437eda1f1deb79c9784bc4b60f1a): comparison url.

Summary: This change led to large relevant mixed results 🤷 in compiler performance.

  • Small improvement in instruction counts (up to -0.4% on full builds of unused-warnings)
  • Large regression in instruction counts (up to 3.0% on incr-unchanged builds of match-stress-enum)

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf +perf-regression

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Dec 5, 2021
@cjgillot cjgillot force-pushed the owner-h2l branch 2 times, most recently from 2602bee to 74c377a Compare December 18, 2021 18:04
@rustbot rustbot added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Dec 18, 2021
@bors

This comment has been minimized.

@cjgillot cjgillot mentioned this pull request Dec 27, 2021
11 tasks
@bors

This comment has been minimized.

@cjgillot cjgillot marked this pull request as ready for review January 22, 2022 22:14
@bors
Copy link
Contributor

bors commented Jan 26, 2022

☔ The latest upstream changes (presumably #93301) made this pull request unmergeable. Please resolve the merge conflicts.

@cjgillot
Copy link
Contributor Author

Replaced by #93301.

@cjgillot cjgillot closed this Jan 27, 2022
@cjgillot cjgillot deleted the owner-h2l branch January 27, 2022 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
perf-regression Performance regression. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants