Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix copy-paste error in String::as_mut_vec() docs #90290

Merged
merged 1 commit into from
Oct 26, 2021

Conversation

nyanpasu64
Copy link
Contributor

@nyanpasu64 nyanpasu64 commented Oct 26, 2021

Did not expect the comments to be perfectly justified... can't wait to be told to change it to Vec<u8>, which destroys the justification 😼

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @m-ou-se (or someone else) soon.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 26, 2021
@nyanpasu64 nyanpasu64 changed the title Fix copy-paste error in String::as_mut_vec() Fix copy-paste error in String::as_mut_vec()'s docs Oct 26, 2021
@nyanpasu64 nyanpasu64 force-pushed the fix-string-as-mut-vec branch from af1b2d8 to 6b90c0f Compare October 26, 2021 06:23
@nyanpasu64 nyanpasu64 changed the title Fix copy-paste error in String::as_mut_vec()'s docs Fix copy-paste error in String::as_mut_vec() docs Oct 26, 2021
@m-ou-se
Copy link
Member

m-ou-se commented Oct 26, 2021

perfectly justified

I love it.

Thanks!

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Oct 26, 2021

📌 Commit 6b90c0f has been approved by m-ou-se

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 26, 2021
@bors
Copy link
Contributor

bors commented Oct 26, 2021

⌛ Testing commit 6b90c0f with merge 612356a...

@bors
Copy link
Contributor

bors commented Oct 26, 2021

☀️ Test successful - checks-actions
Approved by: m-ou-se
Pushing 612356a to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Oct 26, 2021
@bors bors merged commit 612356a into rust-lang:master Oct 26, 2021
@rustbot rustbot added this to the 1.58.0 milestone Oct 26, 2021
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (612356a): comparison url.

Summary: This benchmark run did not return any relevant changes.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants