Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved format-version constant to rustdoc-json-types #89906

Merged

Conversation

yuvaldolev
Copy link
Contributor

Addresses #88620

Moved format-version constant from rustdoc to rustdoc-json-types.

@rust-highfive
Copy link
Collaborator

rustdoc-json-types is a public (although nightly-only) API. Consider changing src/librustdoc/json/conversions.rs instead; otherwise, make sure you update format_version.

cc @CraftSpider,@aDotInTheVoid

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Mark-Simulacrum (or someone else) soon.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 15, 2021
@CraftSpider
Copy link
Contributor

I like this change, keeping the version inline with the definitions

@bors r+

@bors
Copy link
Contributor

bors commented Oct 15, 2021

📌 Commit 43f4ef5 has been approved by CraftSpider

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 15, 2021
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Oct 15, 2021
…ustdoc-json-types, r=CraftSpider

Moved format-version constant to rustdoc-json-types

Addresses rust-lang#88620

Moved format-version constant from rustdoc to rustdoc-json-types.
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Oct 15, 2021
…ustdoc-json-types, r=CraftSpider

Moved format-version constant to rustdoc-json-types

Addresses rust-lang#88620

Moved format-version constant from rustdoc to rustdoc-json-types.
jackh726 added a commit to jackh726/rust that referenced this pull request Oct 16, 2021
…ustdoc-json-types, r=CraftSpider

Moved format-version constant to rustdoc-json-types

Addresses rust-lang#88620

Moved format-version constant from rustdoc to rustdoc-json-types.
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 16, 2021
…askrgr

Rollup of 10 pull requests

Successful merges:

 - rust-lang#89509 (Stabilize `unreachable_unchecked` as `const fn`)
 - rust-lang#89898 (Remove alloc::prelude)
 - rust-lang#89902 (Restrict the aarch64 outline atomics test to Linux)
 - rust-lang#89906 (Moved format-version constant to rustdoc-json-types)
 - rust-lang#89912 (emitter: current substitution can be multi-line)
 - rust-lang#89914 (Emit impl difference error for GenericBoundFailure too)
 - rust-lang#89915 (Some outlives cleanup)
 - rust-lang#89918 (Add some GATs related regression tests)
 - rust-lang#89921 ([fuchsia] Update process info struct)
 - rust-lang#89925 (updating docs to mention usage of AtomicBool)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit e98669a into rust-lang:master Oct 16, 2021
@rustbot rustbot added this to the 1.57.0 milestone Oct 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants