-
Notifications
You must be signed in to change notification settings - Fork 12.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add #[must_use] to remaining alloc functions #89899
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
label
Oct 15, 2021
This comment has been minimized.
This comment has been minimized.
jkugelman
force-pushed
the
must-use-alloc
branch
from
October 15, 2021 00:13
c99f0bb
to
7390e53
Compare
This comment has been minimized.
This comment has been minimized.
jkugelman
force-pushed
the
must-use-alloc
branch
from
October 15, 2021 00:45
7390e53
to
7279584
Compare
nipzu
reviewed
Oct 15, 2021
jkugelman
force-pushed
the
must-use-alloc
branch
from
October 15, 2021 15:46
7279584
to
fb2d0f5
Compare
apiraino
added
the
T-libs
Relevant to the library team, which will review and decide on the PR/issue.
label
Oct 28, 2021
@jkugelman Please do go ahead and add the ones whose only legitimate use for ignoring the return value is leaking memory. (In a separate PR please.) I think it's sufficiently error-prone to call something like |
@bors r+ |
📌 Commit fb2d0f5 has been approved by |
bors
added
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Oct 30, 2021
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 30, 2021
…askrgr Rollup of 4 pull requests Successful merges: - rust-lang#89789 (Add #[must_use] to thread::Builder) - rust-lang#89899 (Add #[must_use] to remaining alloc functions) - rust-lang#90401 (hermit: Implement Condvar::wait_timeout) - rust-lang#90404 (hermitkernel-target: Set OS to "none") Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
joshtriplett
added
the
relnotes
Marks issues that should be documented in the release notes of the next release.
label
Oct 30, 2021
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Oct 31, 2021
…shtriplett Add #[must_use] to alloc functions that would leak memory As [requested](rust-lang#89899 (comment)) by `@joshtriplett.` > Please do go ahead and add the ones whose only legitimate use for ignoring the return value is leaking memory. (In a separate PR please.) I think it's sufficiently error-prone to call something like alloc and ignore the result that it's legitimate to require `let _ =` for that. I added `realloc` myself. Clippy ignored it because of its `mut` argument. ```rust alloc/src/alloc.rs:123:1 alloc unsafe fn realloc(ptr: *mut u8, layout: Layout, new_size: usize) -> *mut u8; ``` Parent issue: rust-lang#89692 r? `@joshtriplett`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
relnotes
Marks issues that should be documented in the release notes of the next release.
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
T-libs
Relevant to the library team, which will review and decide on the PR/issue.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've run out of compelling reasons to group functions together across crates so I'm just going to go module-by-module. This is everything remaining from the
alloc
crate.I ignored these because they might be used to purposefully leak memory... or other allocator shenanigans? I dunno. I'll add them if y'all tell me to.
I don't know why clippy ignored these. I added them myself:
I added these non-mutating
mut
functions:I moved a few existing
#[must_use]
s from functions onto the iterator types they return:IntoIterSorted
,IntoKeys
,IntoValues
.Parent issue: #89692
r? @joshtriplett