Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add some more testcases #89768

Merged
merged 1 commit into from
Oct 13, 2021
Merged

add some more testcases #89768

merged 1 commit into from
Oct 13, 2021

Conversation

hellow554
Copy link
Contributor

@hellow554 hellow554 commented Oct 11, 2021

resolves #52893
resolves #68295
resolves #87750
resolves #88071

All these issues have been fixed according to glacier. Just adding a test so it can be closed.

Can anybody tell me why the github keywords do not work? 🤔
Please edit this post if you can fix it.

@rust-highfive
Copy link
Collaborator

r? @Mark-Simulacrum

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 11, 2021
@rust-log-analyzer

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

@hellow554
Copy link
Contributor Author

I'll try that again tomorrow, when the new nightly is built. On the current nightly (rustc 1.57.0-nightly (41dfaaa 2021-10-10)) it does not ICE. Maybe something happened in the last 17 hours.

@matthiaskrgr
Copy link
Member

I think
fixes #0000
should work? 🤔

@jackh726
Copy link
Member

"resolves" seems to work for github (see "linked issues" on right)

I'll try that again tomorrow, when the new nightly is built. On the current nightly (rustc 1.57.0-nightly (41dfaaa 2021-10-10)) it does not ICE. Maybe something happened in the last 17 hours.

If this is indeed the case, please ping me/file a followup issue; let's nip this in the bud.

@rust-log-analyzer

This comment has been minimized.

@hellow554
Copy link
Contributor Author

The keywords were highlighted before, but they aren't in my current post. That's why I was/am confused.

The testcase of issue 88586 doesn't ICE for me locally, even with nightly-2021-10-11:

$ rustc -vV
rustc 1.57.0-nightly (5b210643e 2021-10-11)
binary: rustc
commit-hash: 5b210643ebf2485aafdf2494de8cf41941a64e95
commit-date: 2021-10-11
host: x86_64-unknown-linux-gnu
release: 1.57.0-nightly
LLVM version: 13.0.0
$ rustc src/test/ui/traits/issue-88586.rs -Z threads=1 -Z ui-testing -Z deduplicate-diagnostics=no -Z emit-future-incompat-report -C codegen-units=1 -C prefer-dynamic -C rpath -C debuginfo=0
error[E0311]: the parameter type `Self` may not live long enough
  --> src/test/ui/traits/issue-88586.rs:5:1
   |
LL | / trait A where
LL | | //~^ ERROR the parameter type `Self` may not live long enough [E0311]
LL | | //~| ERROR the parameter type `Self` may not live long enough [E0311]
LL | |     for<'a> Self: 'a,
LL | | {
LL | | }
   | |_^
   |
   = help: consider adding an explicit lifetime bound `Self: 'a`...
   = note: ...so that the type `Self` will meet its required lifetime bounds...
note: ...that is required by this bound
  --> src/test/ui/traits/issue-88586.rs:8:19
   |
LL |     for<'a> Self: 'a,
   |                   ^^

error[E0311]: the parameter type `Self` may not live long enough
  --> src/test/ui/traits/issue-88586.rs:5:1
   |
LL | / trait A where
LL | | //~^ ERROR the parameter type `Self` may not live long enough [E0311]
LL | | //~| ERROR the parameter type `Self` may not live long enough [E0311]
LL | |     for<'a> Self: 'a,
LL | | {
LL | | }
   | |_^
   |
   = help: consider adding an explicit lifetime bound `Self: 'a`...
   = note: ...so that the type `Self` will meet its required lifetime bounds...
note: ...that is required by this bound
  --> src/test/ui/traits/issue-88586.rs:8:19
   |
LL |     for<'a> Self: 'a,
   |                   ^^

error: aborting due to 2 previous errors

I'll remove that testcase and open a new issue.

@hellow554
Copy link
Contributor Author

Without that testcase it works, CI is done... weird.

@Mark-Simulacrum
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Oct 13, 2021

📌 Commit 0767ed3 has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 13, 2021
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Oct 13, 2021
add some more testcases

resolves rust-lang#52893
resolves rust-lang#68295
resolves rust-lang#87750
resolves rust-lang#88071

All these issues have been fixed according to glacier. Just adding a test so it can be closed.

Can anybody tell me why the github keywords do not work? 🤔
Please edit this post if you can fix it.
the8472 added a commit to the8472/rust that referenced this pull request Oct 13, 2021
add some more testcases

resolves rust-lang#52893
resolves rust-lang#68295
resolves rust-lang#87750
resolves rust-lang#88071

All these issues have been fixed according to glacier. Just adding a test so it can be closed.

Can anybody tell me why the github keywords do not work? 🤔
Please edit this post if you can fix it.
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 13, 2021
Rollup of 12 pull requests

Successful merges:

 - rust-lang#89768 (add some more testcases)
 - rust-lang#89777 (Edit explanation of test for nested type ascriptions)
 - rust-lang#89781 (Add missing words in `Infallible` docs)
 - rust-lang#89782 (Improve CJK font in rustdoc)
 - rust-lang#89794 (Add #[must_use] to to_value conversions)
 - rust-lang#89814 (Fix uppercase/lowercase error)
 - rust-lang#89816 (Fix invalid rules in .gitignore)
 - rust-lang#89817 (Add #[inline] to int log10 functions.)
 - rust-lang#89818 (Use Option::map_or instead of open coding it)
 - rust-lang#89828 (Fix config.toml overflow-checks options)
 - rust-lang#89840 (fix the stage0 tools config file path in `config.toml.example`)
 - rust-lang#89845 (Add davidtwco to the `.mailmap`)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 0caa616 into rust-lang:master Oct 13, 2021
@rustbot rustbot added this to the 1.57.0 milestone Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
8 participants