Rollup of 14 pull requests #89548
Closed
Rollup of 14 pull requests #89548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…solute path but in case of failure (e.g. prcfs not mounted) still using getexecname.
…rch64 aarch64 prior to v8.4 (FEAT_LSE2) doesn't have an instruction that guarantees untorn 128b reads except for completing a 128b load/store exclusive pair (ldxp/stxp) or compare-and-swap (casp) successfully. The requirement to complete a 128b read+write atomic is actually more expensive and more unfair than the previous implementation of monotonize() which used a Mutex on aarch64, especially at large core counts. For aarch64 switch to the 64b atomic implementation which is about 13x faster for a benchmark that involves many calls to Instant::now().
… that overlay row entries after a UA specific amount of rows
Fixes rust-lang#73159 This is similar to rust-lang#69350 - if the user didn't initially write out a 'static lifetime, adding 'static in response to a lifetime error is usually the wrong thing to do.
The old JavaScript didn't work. It filled the browser console with "e.previousElementSibling not defined" errors, because it didn't account for the example-wrap div that a newer version of rustdoc added. Additionally, it had copied versions of utility functions that had been optimized in rustdoc main.js. This version updates those.
os current_exe using same approach as linux to get always the full ab… …solute path
…tive, r=jyn514 rustdoc-json: Don't ignore impls for primitive types Fix the issue discussed at [Zulip](https://rust-lang.zulipchat.com/#narrow/stream/266220-rustdoc/topic/.E2.9C.94.20Json.20output.20lacks.20some.20item.20which.20are.20supposed.20to.20be.20there) r? `@jyn514`
…4, r=dtolnay Use the 64b inner:monotonize() implementation not the 128b one for aarch64 aarch64 prior to v8.4 (FEAT_LSE2) doesn't have an instruction that guarantees untorn 128b reads except for completing a 128b load/store exclusive pair (ldxp/stxp) or compare-and-swap (casp) successfully. The requirement to complete a 128b read+write atomic is actually more expensive and more unfair than the previous implementation of monotonize() which used a Mutex on aarch64, especially at large core counts. For aarch64 switch to the 64b atomic implementation which is about 13x faster for a benchmark that involves many calls to Instant::now().
Added abs_diff for integer types. Closes rust-lang#62111.
…nts, r=GuillaumeGomez Rustdoc migrate to table so the gui can handle >2k constants Closes rust-lang#88545. This PR adds a test for overlapping entries in the `item-table` rust-lang#88545 It currently includes the commit with the workaround from rust-lang#88776
…_private, r=joshtriplett refactor: VecDeques PairSlices fields to private Reducing VecDeque's PairSlices fields to private, a `from(...)` method is already used to create PairSlices.
… r=Mark-Simulacrum rustdoc-json: Encode json files with UTF-8 Currently, `check_missing_items.py` malfunctions when the index contains some letters like emojis. Related to rust-lang#89360.
Update to the final LLVM 13.0.0 release
…, r=nagisa haiku thread affinity build fix
…lett Fix extra `non_snake_case` warning for shorthand field bindings Fixes rust-lang#89469. The problem is the innermost `if` condition here: https://github.com/rust-lang/rust/blob/d14731cb3ced8318d7fc83cbe838f0e7f2fb3b40/compiler/rustc_lint/src/nonstandard_style.rs#L435-L452 This code runs for every `PatKind::Binding`, so if a struct has multiple fields, say A and B, and both are bound in a pattern using shorthands, the call to `self.check_snake_case()` will indeed be skipped in the `check_pat()` call for `A`; but when `check_pat()` is called for `B`, the loop will still iterate over `A`, and `field.ident (= A) != ident (= B)` will be true. I have fixed this by only looking at non-shorthand bindings, and only the binding that `check_pat()` was actually called for.
…shtriplett Follow the diagnostic output style guide Detected by rust-lang#89455.
Deny `where` clauses on `auto` traits Fixes rust-lang#84075.
…tsakis Don't suggest replacing region with 'static in NLL Fixes rust-lang#73159 This is similar to rust-lang#69350 - if the user didn't initially write out a 'static lifetime, adding 'static in response to a lifetime error is usually the wrong thing to do.
…erator-js, r=Mark-Simulacrum fix busted JavaScript in error index generator The old JavaScript didn't work. It filled the browser console with "e.previousElementSibling not defined" errors, because it didn't account for the example-wrap div that a newer version of rustdoc added. Additionally, it had copied versions of utility functions that had been optimized in rustdoc main.js. This version updates those.
|
📌 Commit efeb9af has been approved by |
bors
added
the
S-waiting-on-bors
|
⌛ Testing commit efeb9af with merge 5969d70f72019830097b0e08e05608e71aece533... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
non_snake_casewarning for shorthand field bindings #89473 (Fix extranon_snake_casewarning for shorthand field bindings)whereclauses onautotraits #89494 (Denywhereclauses onautotraits)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup