-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rustc: Remove local variable IDs from Export
s
#88677
Conversation
Some changes occurred in src/tools/clippy. cc @rust-lang/clippy |
r? @davidtwco (rust-highfive has picked a reviewer for you, use r? to override) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@bors r+ |
📌 Commit 7f651948dea239fe45d6b1e564dc799ab4e3f894 has been approved by |
This comment has been minimized.
This comment has been minimized.
Local variables can never be exported.
7f65194
to
294510e
Compare
@bors r=davidtwco |
📌 Commit 294510e has been approved by |
rustc: Remove local variable IDs from `Export`s Local variables can never be exported.
rustc: Remove local variable IDs from `Export`s Local variables can never be exported.
rustc: Remove local variable IDs from `Export`s Local variables can never be exported.
rustc: Remove local variable IDs from `Export`s Local variables can never be exported.
…arth Rollup of 7 pull requests Successful merges: - rust-lang#88336 ( Detect stricter constraints on gats where clauses in impls vs trait) - rust-lang#88677 (rustc: Remove local variable IDs from `Export`s) - rust-lang#88699 (Remove extra unshallow from cherry-pick checker) - rust-lang#88709 (generic_const_exprs: use thir for abstract consts instead of mir) - rust-lang#88711 (Rework DepthFirstSearch API) - rust-lang#88810 (rustdoc: Cleanup `clean` part 1) - rust-lang#88813 (explicitly link to external `ena` docs) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
The rollup caused an instruction count increase on perf, do you think that's due to this PR? |
It seems unlikely, this PR is a type-level refactoring that shouldn't change anything at runtime. |
rustc: Remove local variable IDs from `Export`s Local variables can never be exported.
Local variables can never be exported.