Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hir::GenericBound::Unsized #88061

Merged
merged 4 commits into from
Sep 8, 2021
Merged

Conversation

jackh726
Copy link
Member

Rather than "moving" the ?Sized bounds to the param bounds, just also check where clauses in astconv. I also did some related cleanup here, but that's not strictly neccesary. Also going to do a perf run here.

r? @estebank

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 15, 2021
@jackh726
Copy link
Member Author

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Aug 15, 2021
@bors
Copy link
Contributor

bors commented Aug 15, 2021

⌛ Trying commit 037f6e7 with merge 8362fb41daff715052b561141047044753cdc3e8...

@bors
Copy link
Contributor

bors commented Aug 15, 2021

☀️ Try build successful - checks-actions
Build commit: 8362fb41daff715052b561141047044753cdc3e8 (8362fb41daff715052b561141047044753cdc3e8)

@rust-timer
Copy link
Collaborator

Queued 8362fb41daff715052b561141047044753cdc3e8 with parent c0490a2, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking try commit (8362fb41daff715052b561141047044753cdc3e8): comparison url.

Summary: This benchmark run did not return any significant changes.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Aug 15, 2021
Copy link
Contributor

@estebank estebank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursory look at the code changes make sense. When I introduced Unsized I think there were some comments that I replaced that we might want to bring back.

@jackh726 jackh726 force-pushed the genericbound-cleanup branch from 037f6e7 to 08ec7ba Compare August 18, 2021 03:41
@jackh726
Copy link
Member Author

@estebank can you be more clear? The only comment (I think) that you replaced was in item.rs referring to discarding the ?Sized bounds from where clauses, but that's no longer special cased.

@inquisitivecrystal inquisitivecrystal added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Aug 24, 2021
@bors
Copy link
Contributor

bors commented Aug 28, 2021

☔ The latest upstream changes (presumably #88328) made this pull request unmergeable. Please resolve the merge conflicts.

@estebank
Copy link
Contributor

r=me after rebase

@jackh726 jackh726 added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 3, 2021
@jackh726 jackh726 force-pushed the genericbound-cleanup branch from 08ec7ba to 22ef04e Compare September 7, 2021 22:26
@jackh726
Copy link
Member Author

jackh726 commented Sep 7, 2021

@bors r=estebank

@bors
Copy link
Contributor

bors commented Sep 7, 2021

📌 Commit 22ef04e has been approved by estebank

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 7, 2021
@jackh726 jackh726 closed this Sep 8, 2021
@jackh726 jackh726 reopened this Sep 8, 2021
@jackh726
Copy link
Member Author

jackh726 commented Sep 8, 2021

@bors r=estebank

@bors
Copy link
Contributor

bors commented Sep 8, 2021

💡 This pull request was already approved, no need to approve it again.

@bors
Copy link
Contributor

bors commented Sep 8, 2021

📌 Commit 22ef04e has been approved by estebank

@bors
Copy link
Contributor

bors commented Sep 8, 2021

⌛ Testing commit 22ef04e with merge 72969f6...

@bors
Copy link
Contributor

bors commented Sep 8, 2021

☀️ Test successful - checks-actions
Approved by: estebank
Pushing 72969f6 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 8, 2021
@bors bors merged commit 72969f6 into rust-lang:master Sep 8, 2021
@rustbot rustbot added this to the 1.57.0 milestone Sep 8, 2021
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (72969f6): comparison url.

Summary: This benchmark run did not return any relevant changes.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

@jackh726 jackh726 deleted the genericbound-cleanup branch September 8, 2021 12:21
@jackh726 jackh726 restored the genericbound-cleanup branch March 12, 2022 18:30
@jackh726 jackh726 deleted the genericbound-cleanup branch March 12, 2022 18:35
@jackh726 jackh726 restored the genericbound-cleanup branch March 12, 2022 18:43
@jackh726 jackh726 deleted the genericbound-cleanup branch March 12, 2022 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants