-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Liberate before normalizing in wfcheck #87113
Conversation
@bors try @rust-timer queue |
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
⌛ Trying commit 166d602 with merge efd671be08a7ed6025e86da94a4224436d0c218c... |
Oh interesting, looks like this changes test output |
@bors try |
⌛ Trying commit 26e4fa5 with merge 437a1916f2bddb8794de1b3ef98fdab9ee814118... |
☀️ Try build successful - checks-actions |
Queued 437a1916f2bddb8794de1b3ef98fdab9ee814118 with parent 3e1c75c, future comparison URL. |
Finished benchmarking try commit (437a1916f2bddb8794de1b3ef98fdab9ee814118): comparison url. Summary: This benchmark run did not return any significant changes. If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. @bors rollup=never |
These were included in #86993 |
Split from #85499 and #86993
Hopefully this is the perf regression in those. This is a correctness fix (though it doesn't do anything without those changes).
r? @nikomatsakis