Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

alloc: no_global_oom_handling: disable new()s, pin()s, etc. #86810

Merged
merged 1 commit into from
Jul 3, 2021
Merged

alloc: no_global_oom_handling: disable new()s, pin()s, etc. #86810

merged 1 commit into from
Jul 3, 2021

Conversation

ojeda
Copy link
Contributor

@ojeda ojeda commented Jul 2, 2021

They are infallible, and could not be actually used because
they will trigger an error when monomorphized, but it is better
to just remove them.

Link: Rust-for-Linux/linux#402
Suggested-by: Gary Guo [email protected]
Signed-off-by: Miguel Ojeda [email protected]

@ojeda
alloc: no_global_oom_handling: disable new()s, pin()s, etc.
7775dff 
They are infallible, and could not be actually used because
they will trigger an error when monomorphized, but it is better
to just remove them.

Link: Rust-for-Linux/linux#402
Suggested-by: Gary Guo <[email protected]>
Signed-off-by: Miguel Ojeda <[email protected]>
@rust-highfive
Copy link
Collaborator

r? @dtolnay

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 2, 2021
@ojeda
Copy link
Contributor Author

ojeda commented Jul 2, 2021

Paging @nbdd0121 @bjorn3 @Ericson2314.

@ojeda ojeda mentioned this pull request Jul 2, 2021
Open
7 tasks
dtolnay
dtolnay approved these changes Jul 3, 2021
View reviewed changes
Copy link
Member

@dtolnay dtolnay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dtolnay
Copy link
Member

dtolnay commented Jul 3, 2021

@bors r+

@bors
Copy link
Contributor

bors commented Jul 3, 2021

📌 Commit 7775dff has been approved by dtolnay

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 3, 2021
@bors
Copy link
Contributor

bors commented Jul 3, 2021

⌛ Testing commit 7775dff with merge 8649737...

@bors
Copy link
Contributor

bors commented Jul 3, 2021

☀️ Test successful - checks-actions
Approved by: dtolnay
Pushing 8649737 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 3, 2021
@bors bors merged commit 8649737 into rust-lang:master Jul 3, 2021
@rustbot rustbot added this to the 1.55.0 milestone Jul 3, 2021
@kornelski
Copy link
Contributor

kornelski commented Jul 8, 2021 •
edited
Loading

BTW @ojeda, the double negation in cfg(not(no_global_oom_handling)) is hard to read. Maybe the feature flag could be inverted to be default-on global_oom_handling and then use cfg(global_oom_handling)?

@bjorn3
Copy link
Member

bjorn3 commented Jul 8, 2021

A default-on --cfg that is not a feature is not possible. Using a cargo feature was deliberately avoided.

@ojeda ojeda deleted the alloc-gate branch July 8, 2021 14:11
@ojeda
Copy link
Contributor Author

ojeda commented Jul 8, 2021

@kornelski Note that this PR did not add the cfg, it merely tags more methods.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtolnay dtolnay dtolnay approved these changes

@Ericson2314 Ericson2314 Ericson2314 approved these changes

Assignees

@dtolnay dtolnay

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.55.0
Development

Successfully merging this pull request may close these issues.
8 participants
@ojeda @rust-highfive @dtolnay @bors @kornelski @bjorn3 @Ericson2314 @rustbot