-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pretty print generator witness only in -Zverbose
mode
#86240
Conversation
r? @estebank (rust-highfive has picked a reviewer for you, use r? to override) |
0bef4cd
to
78b981f
Compare
@bors try @rust-timer queue |
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
⌛ Trying commit 78b981fe115633ab7214445101473349cbdfc3ab with merge 3475950431a8883d7ca11420c9954459c70a0b95... |
☀️ Try build successful - checks-actions |
Queued 3475950431a8883d7ca11420c9954459c70a0b95 with parent b84ffce, future comparison URL. |
Finished benchmarking try commit (3475950431a8883d7ca11420c9954459c70a0b95): comparison url. Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up. @bors rollup=never |
📌 Commit 78b981fe115633ab7214445101473349cbdfc3ab has been approved by |
⌛ Testing commit 78b981fe115633ab7214445101473349cbdfc3ab with merge 1a3665a8aa94e4c017cb09ac7292dffb843a9469... |
This comment has been minimized.
This comment has been minimized.
💔 Test failed - checks-actions |
In release build of deeply-nested-async benchmark the size of `no-opt.bc` file is reduced from 46MB to 62kB.
78b981f
to
06ca736
Compare
Rebased and updated output of a test case added in #86215. |
@bors r+ |
📌 Commit 06ca736 has been approved by |
☀️ Test successful - checks-actions |
This PR seems to have fixed my exponential compile times issue mentioned in #84873! 🎉 That is, compile times return to normal between nightly 2021-06-12 and 2021-06-13. |
In release build of deeply-nested-async benchmark the size of
no-opt.bc
file is reduced from 46MB to 62kB.Helps with #84873, where in one of reported test cases the size of
no-opt.bc
file is reduced from 2.3GB to 799kB.