-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[beta] Disable mutable noalias for Rust 1.53 #86036
Conversation
|
@bors r+ rollup=never |
📌 Commit bbd370c has been approved by |
⌛ Testing commit bbd370c with merge 40371dc0330c5f64c61bf865a6233c3fb14e6960... |
The job Click to see the possible cause of the failure (guessed by this bot)
|
💔 Test failed - checks-actions |
I want to get off Mr. Noalias' Wild Ride |
Looks like this build failure has occurred for all recent beta merge attempts :( |
⌛ Testing commit bbd370c with merge c22eb33f9bdbc61cfc30a04c53d5469424f8cbec... |
💔 Test failed - checks-actions |
…acrum [beta] Backport rust-lang#84894 to fix beta CI Currently, beta backports fail with this failure: rust-lang#86036 (comment) ``` STL1000: Unexpected compiler version, expected Clang 11.0.0 or newer. ``` The previous beta backport was successful because it uses a Visual Studio tool v14.28.29910 but now CI uses v14.29.30037. rust-lang#84894 updated clang to 12 so master didn't catch this change, I guess. Hopefully, it fixes CI failures on beta.
The job Click to see the possible cause of the failure (guessed by this bot)
|
CI issue has been fixed, @bors retry |
☀️ Test successful - checks-actions |
I know it is no fun to do this, but it is the right call. Thanks for doing this. |
Add mutable-noalias to the release notes for 1.54 It was enabled in rust-lang#82834 and disabled in 1.53 by rust-lang#86036, but it was never disabled on (then) nightly, so it still landed in 1.54. This was mentioned on rust-lang#86696 but never made it into the release notes. r? `@XAMPPRocky` cc `@nikic`
Disable mutable noalias for the upcoming release to give this change more time to bake. I believe that was the consensus, and I wanted to make sure we don't forget :)
r? @Mark-Simulacrum