Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Driver improvements #85810

Merged
merged 13 commits into from
Jun 7, 2021
Merged

Driver improvements #85810

merged 13 commits into from
Jun 7, 2021

Conversation

bjorn3
Copy link
Member

@bjorn3 bjorn3 commented May 29, 2021

This PR contains a couple of cleanups for the driver and a few small improvements for the custom codegen backend interface. It also implements --version and -Cpasses=list support for custom codegen backends.

@rust-highfive
Copy link
Collaborator

Some changes occured to rustc_codegen_cranelift

cc @bjorn3

@rust-highfive
Copy link
Collaborator

r? @varkor

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 29, 2021
@bjorn3 bjorn3 added A-driver Area: rustc_driver that ties everything together into the `rustc` compiler C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels May 29, 2021
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bjorn3 bjorn3 force-pushed the further_driver_cleanup branch 2 times, most recently from c6e8b4b to 3753457 Compare May 29, 2021 17:19
@bjorn3 bjorn3 mentioned this pull request May 30, 2021
Merged
@bjorn3
Copy link
Member Author

bjorn3 commented May 30, 2021

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label May 30, 2021
@bors
Copy link
Contributor

bors commented May 30, 2021

⌛ Trying commit 3753457cfed654d730a9f6c9e8fceaba295b668f with merge f484bc0cdcc82a00541b6f91df1f07c698a37931...

@bors
Copy link
Contributor

bors commented May 30, 2021

☀️ Try build successful - checks-actions
Build commit: f484bc0cdcc82a00541b6f91df1f07c698a37931 (f484bc0cdcc82a00541b6f91df1f07c698a37931)

@rust-timer
Copy link
Collaborator

Queued f484bc0cdcc82a00541b6f91df1f07c698a37931 with parent 5957990, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking try commit (f484bc0cdcc82a00541b6f91df1f07c698a37931): comparison url.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying rollup- to bors.

Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label May 31, 2021
@bjorn3
Copy link
Member Author

bjorn3 commented May 31, 2021

This is a slight improvement with only a few small regressions.

@bjorn3 bjorn3 mentioned this pull request Jun 1, 2021
Merged
@bjorn3
Copy link
Member Author

bjorn3 commented Jun 1, 2021

Rebased on d209114.

bjorn3 added 13 commits June 4, 2021 13:20
@bjorn3
Provide a default provide* implementation for CodegenBackend
092bc2b 
Both cg_llvm and cg_clif don't override it. cg_spirv does override it,
so it needs to be preserved.
@bjorn3
Remove unnecessary wasm_import_module_map provide
f299256 
For extern providers, both provide and provide_extern are called.
wasm_import_module_map is already provided in provide, so it doesn't
need to be provided in provide_extern.
@bjorn3
Turn a regular comment on Compilation into a doc comment
a702729
@bjorn3
A couple of small cleanups
45c9775
@bjorn3
Provide default MetadataLoader
f04a2d3
@bjorn3
Allow printing the version of the default codegen backend if it isn't…
1870f9b 
… llvm
@bjorn3
Use SyncOnceCell in get_codegen_backend
d96446c 
This reduces the amount of unsafe code in get_codegen_backend
@bjorn3
Support --version and -Cpasses=list for other codegen backends
c1b6637
@bjorn3
Remove unused imports
f8ed66b
@bjorn3
Move windows_subsystem field from CodegenResults to CrateInfo
9624701
@bjorn3
Move crate_name field from OngoingCodegen to CrateInfo
e30490d
@bjorn3
Rustfmt
7d5c794
@bjorn3
Update hotplug codegen backend test
435b540
@varkor
Copy link
Member

varkor commented Jun 6, 2021

@bors r+

@bors
Copy link
Contributor

bors commented Jun 6, 2021

📌 Commit 435b540 has been approved by varkor

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 6, 2021
@bors
Copy link
Contributor

bors commented Jun 7, 2021

⌛ Testing commit 435b540 with merge cc9610b...

@bors
Copy link
Contributor

bors commented Jun 7, 2021

☀️ Test successful - checks-actions
Approved by: varkor
Pushing cc9610b to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jun 7, 2021
@bors bors merged commit cc9610b into rust-lang:master Jun 7, 2021
@rustbot rustbot added this to the 1.54.0 milestone Jun 7, 2021
@bjorn3 bjorn3 deleted the further_driver_cleanup branch June 7, 2021 05:58
@adpaco-aws adpaco-aws mentioned this pull request Jun 7, 2021
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 11, 2021
@bors
Auto merge of rust-lang#85885 - bjorn3:remove_box_region, r=cjgillot
0a8629b 
Don't use a generator for BoxedResolver

The generator is non-trivial and requires unsafe code anyway. Using regular unsafe code without a generator is much easier to follow.

Based on rust-lang#85810 as it touches rustc_interface too.
bjorn3 pushed a commit to bjorn3/rust that referenced this pull request Jul 7, 2021
@bors
Auto merge of rust-lang#85810 - bjorn3:further_driver_cleanup, r=varkor
ab73115 
Driver improvements

This PR contains a couple of cleanups for the driver and a few small improvements for the custom codegen backend interface. It also implements `--version` and `-Cpasses=list` support for custom codegen backends.
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 26, 2021
@bors
Auto merge of rust-lang#85830 - bjorn3:separate_provide_extern, r=cjg…
17e13b5 
…illot

 Avoid a branch on key being local for queries that use the same local and extern providers

Currently based on rust-lang#85810 as it slightly conflicts with it. Only the last two commits are new.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@varkor varkor

Labels
A-driver Area: rustc_driver that ties everything together into the `rustc` compiler C-cleanup Category: PRs that clean code up or issues documenting cleanup. merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.54.0
Development

Successfully merging this pull request may close these issues.
7 participants
@bjorn3 @rust-highfive @rust-log-analyzer @rust-timer @bors @varkor @rustbot