WIP - fix coverage in attr macro spans #85173
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
|
☔ The latest upstream changes (presumably #84278) made this pull request unmergeable. Please resolve the merge conflicts. |
Fixes: rust-lang#84018 With `-Z instrument-coverage`, coverage reporting of dead blocks (for example, blocks dropped because a conditional branch is dropped, based on const evaluation) is now supported. Note, this PR relands an earlier, reverted PR that failed when compiling generators. Generators clone blocks, so CFG simplification is used to remove the original `BasicBlocks`; and since they were cloned, the original blocks should not be saved. (Saving them resulted in duplicate coverage counters, and `llvm-cov` failed with a "Malformed coverage data" error. If `instrument-coverage` is enabled, `simplify::remove_dead_blocks_with_coverage()`, with `DroppedCoverage::SaveUnreachable`, finds all dropped coverage `Statement`s and adds their `code_region`s as `Unreachable` coverage `Statement`s to the `START_BLOCK`, so they are still included in the coverage map. Check out the resulting changes in the test coverage reports in this PR.
richkadel
force-pushed
the
fuchsia-async-2
branch
from
86a4979 to
6aece07
Compare
This comment has been minimized.
This comment has been minimized.
Such as #[fuchsia_async::run_singlethreaded] Note the spanview output seems to show good coverage spans, but when running coverage reports, the fuchsia_async functions showed `0` for coverage of tests that ran once, and `llvm-cov` reports a Malformed Coverage error.
richkadel
force-pushed
the
fuchsia-async-2
branch
from
6aece07 to
1d7b248
Compare
|
Closing this PR because I was able to resolve the problem by fixing the proc macro (in the specific case). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Such as
#[fuchsia_async::run_singlethreaded]Note the spanview output seems to show good coverage spans, but when
running coverage reports, the fuchsia_async functions showed
0forcoverage of tests that ran once, and
llvm-covreports a MalformedCoverage error.
r? @tmandry