-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce amount of function pointers in query invocation. #85154
Conversation
@bors try @rust-timer queue |
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
⌛ Trying commit 54812b2fc5138b294a94bcef06a0862dd702c587 with merge c2b73ae0efbe925df17fdc16e66fa801d11da357... |
☀️ Try build successful - checks-actions |
Queued c2b73ae0efbe925df17fdc16e66fa801d11da357 with parent 544d124, future comparison URL. |
Finished benchmarking try commit (c2b73ae0efbe925df17fdc16e66fa801d11da357): comparison url. Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up. @bors rollup=never |
Mostly improvements up to 0.5%, but also a couple of regressions up to 1.6%. |
@bors try @rust-timer queue |
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
⌛ Trying commit 28ebdc070e4f5a3f300bc6893f463917bb1296f2 with merge 19f38705d2fff4b15315f9aea07919014862c418... |
☀️ Try build successful - checks-actions |
Queued 19f38705d2fff4b15315f9aea07919014862c418 with parent 428636f, future comparison URL. |
Finished benchmarking try commit (19f38705d2fff4b15315f9aea07919014862c418): comparison url. Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up. @bors rollup=never |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall improvements up to 0.6% with only a few small regressions up to 0.3%. No impact on bootstrap time.
This comment has been minimized.
This comment has been minimized.
☔ The latest upstream changes (presumably #85319) made this pull request unmergeable. Please resolve the merge conflicts. |
Looks like it's ready to review? |
Nobody is assigned yet. |
@bors r+ |
📌 Commit 8ed82eb has been approved by |
☀️ Test successful - checks-actions |
r? @ghost