Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow checking miri and RLS with x.py check src/tools/{miri,rls} #85051

Merged
merged 1 commit into from
May 11, 2021

Conversation

jyn514
Copy link
Member

@jyn514 jyn514 commented May 7, 2021

Helps with #80639.

@Xanewok would you find this useful for RLS too?

@rust-highfive
Copy link
Collaborator

r? @Mark-Simulacrum

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 7, 2021
@rust-log-analyzer

This comment has been minimized.

@jyn514
Copy link
Member Author

jyn514 commented May 7, 2021

Oh hmm I think checking miri needs to be off by default since it's out-of-tree.

@Xanewok
Copy link
Member

Xanewok commented May 7, 2021

If this doesn't add extra maintenance and this adds support for x.py check src/tools/rls in addition to x.py test src/tools/rls, then I think it'd make a great addition I'd say, yeah.

@jyn514
Copy link
Member Author

jyn514 commented May 7, 2021

If this doesn't add extra maintenance

Nope, adding things to check is super easy :)

@jyn514
Copy link
Member Author

jyn514 commented May 7, 2021

cc @RalfJung btw - hopefully this is helpful :)

@jyn514 jyn514 changed the title Allow checking miri with x.py check src/tools/miri Allow checking miri and RLS with x.py check src/tools/{miri,rls} May 7, 2021
@Mark-Simulacrum
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented May 10, 2021

📌 Commit e4b57e1 has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 10, 2021
bors added a commit to rust-lang-ci/rust that referenced this pull request May 11, 2021
Rollup of 7 pull requests

Successful merges:

 - rust-lang#84777 (Apply `--cfg parallel_compiler` when documenting)
 - rust-lang#84783 (Allow formatting specific subdirectories)
 - rust-lang#84998 (Show nicer error when an 'unstable fingerprints' error occurs)
 - rust-lang#85002 (RELEASES.md: Use broken_intra_doc_links as an example, not nightly lint)
 - rust-lang#85051 (Allow checking miri and RLS with `x.py check src/tools/{miri,rls}`)
 - rust-lang#85114 (Remove outdated FIXME for download-rustc)
 - rust-lang#85143 (Document Rc::from)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit d501042 into rust-lang:master May 11, 2021
@rustbot rustbot added this to the 1.54.0 milestone May 11, 2021
@jyn514 jyn514 deleted the check-miri branch May 11, 2021 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants