Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync rustc_codegen_cranelift #84749

Merged
merged 61 commits into from
May 1, 2021
Merged

Conversation

XAMPPRocky
Copy link
Member

@XAMPPRocky XAMPPRocky commented Apr 30, 2021

Retrying #84746

r? @bjorn3


Edit(bjorn3): Since the last sync there have been some refactorings around the driver code in preparation for a planned new feature. In addition @mominul implemented -Ctarget-cpu support and @XAMPPRocky fixed compilation of cg_clif itself for Windows with the MSVC toolchain.

bjorn3 and others added 30 commits March 29, 2021 10:45
This wrapper implements StableAddress and falls back to directly reading
the file on wasm32
This doesn't enable unwinding as cg_clif doesn't support it yet. It does
allow for linking to a cg_llvm compiled libstd.so, which uses
`-Cpanic=unwind`.
It is broken and needs to be rewritten from scratch
It isn't effective with the new backend framework
This reverts commit afe74d7. It
shouldn't have been pushed to master as it isn't ready yet.
Changes `librustc_X` to `rustc_X`, only in documentation comments.
Plain code comments are left unchanged.

Also fix incorrect file paths.
This simplifies the jit driver a lot
@rust-highfive
Copy link
Collaborator

Some changes occured to rustc_codegen_cranelift

cc @bjorn3

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 30, 2021
@bjorn3
Copy link
Member

bjorn3 commented Apr 30, 2021

Looks like you included the entirety of #81746 in this PR too.

Edit: Didn't see #81746 (comment) yet. I would prefer making a new PR as the sync should be fine as is, but the rest will need to be reviewed independently.

@bjorn3
Copy link
Member

bjorn3 commented Apr 30, 2021

@rustbot label +A-codegen +A-cranelift +T-compiler

@bors r+

@rustbot rustbot added A-codegen Area: Code generation A-cranelift Things relevant to the [future] cranelift backend T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 30, 2021
@bors
Copy link
Contributor

bors commented Apr 30, 2021

📌 Commit ef53ebc has been approved by bjorn3

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 30, 2021
JohnTitor added a commit to JohnTitor/rust that referenced this pull request May 1, 2021
Sync `rustc_codegen_cranelift`

Retrying rust-lang#84746

r? `@bjorn3`

---

Edit(bjorn3): Since the last sync there have been some refactorings around the driver code in preparation for a planned new feature. In addition `@mominul` implemented `-Ctarget-cpu` support and `@XAMPPRocky` fixed compilation of cg_clif itself for Windows with the MSVC toolchain.
bors added a commit to rust-lang-ci/rust that referenced this pull request May 1, 2021
Rollup of 8 pull requests

Successful merges:

 - rust-lang#84601 (rustdoc: Only store locations in Cache::extern_locations and calculate the other info on-demand)
 - rust-lang#84704 (platform-support.md: Update for consistency with Target Tier Policy)
 - rust-lang#84724 (Replace llvm::sys::fs::F_None with llvm::sys::fs::OF_None)
 - rust-lang#84740 (Reset the docs' copy path button after 1 second)
 - rust-lang#84749 (Sync `rustc_codegen_cranelift`)
 - rust-lang#84756 (Add a ToC to the Target Tier Policy documentation)
 - rust-lang#84765 (Update cargo)
 - rust-lang#84774 (Fix misspelling)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit fc850b6 into rust-lang:master May 1, 2021
@rustbot rustbot added this to the 1.54.0 milestone May 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-codegen Area: Code generation A-cranelift Things relevant to the [future] cranelift backend S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants