Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 5 pull requests #83896

Closed
wants to merge 14 commits into from

Commits on Apr 4, 2021

  1. Configuration menu
    Copy the full SHA
    af7c540 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    9cdaea3 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    48acdb7 View commit details
    Browse the repository at this point in the history

Commits on Apr 5, 2021

  1. ⬆️ rust-analyzer

    lnicola committed Apr 5, 2021
    Configuration menu
    Copy the full SHA
    6ce9a02 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d63b3f9 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    ac04dbd View commit details
    Browse the repository at this point in the history
  4. Use more appropriate return type for resolve_associated_item

    Previously, the types looked like this:
    
    - None means this is not an associated item (but may be a variant field)
    - Some(Err) means this is known to be an error. I think the only way that can happen is if it resolved and but you had your own anchor.
    - Some(Ok(_, None)) was impossible.
    
    Now, this returns a nested Option and does the error handling and
    fiddling with the side channel in the caller. As a side-effect, it also
    removes duplicate error handling.
    
    This has one small change in behavior, which is that
    `resolve_primitive_associated_item` now goes through `variant_field` if
    it fails to resolve something.  This is not ideal, but since it will be
    quickly rejected anyway, I think the performance hit is worth the
    cleanup.
    
    This also fixes a bug where struct fields would forget to set the side
    channel, adds a test for the bug, and ignores `private_intra_doc_links`
    in rustc_resolve (since it's always documented with
    --document-private-items).
    jyn514 committed Apr 5, 2021
    Configuration menu
    Copy the full SHA
    3b7e654 View commit details
    Browse the repository at this point in the history
  5. Document compiler/ with -Aprivate-intra-doc-links

    Since compiler/ always passes --document-private-items, it's ok to link
    to items that are private.
    jyn514 committed Apr 5, 2021
    Configuration menu
    Copy the full SHA
    0a351ab View commit details
    Browse the repository at this point in the history
  6. Add config file for tools enabling stage1 downloads by default

    Otherwise no one will be able to find the setting.
    jyn514 committed Apr 5, 2021
    Configuration menu
    Copy the full SHA
    f8653c9 View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#83370 - jyn514:setup-tools, r=Mark-Simulacrum

    Add `x.py setup tools` which enables `download-rustc` by default
    
    Helps with rust-lang#81930. I know I said in that issue that I should fix that rebasing rebuilds bootstrap, but the compile time improvement is so good I think it's ok to leave that fix for later (I still plan to work on it). I think all the outright bugs have been fixed :)
    
    This builds on rust-lang#83368 so I can set the option to `if-unchanged`.
    
    r? `@Mark-Simulacrum`
    Dylan-DPC authored Apr 5, 2021
    Configuration menu
    Copy the full SHA
    f3cc923 View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#83607 - Berrysoft:master, r=nagisa

    Add `__CxxFrameHandler3` in `panic_abort`
    
    Fix rust-lang#54137
    
    <del>I initially tried to forward to `__CxxFrameHandler3` from `rust_eh_personality`, but later I found that LLVM uses handler names to distinguish exception type. Therefore I choose to add `__CxxFrameHandler3` in `panic_abort`. Anyway it solves the link problem, and this function will never be called.</del>
    
    It seems that the original issue was solved, but still adding these tests.
    Dylan-DPC authored Apr 5, 2021
    Configuration menu
    Copy the full SHA
    52437be View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#83849 - jyn514:intra-doc-cleanup, r=bugadani

    rustdoc: Cleanup handling of associated items for intra-doc links
    
    Helps with rust-lang#83761 (right now the uses of the resolver are all intermingled with uses of the tyctxt). Best reviewed one commit at a time.
    
    r? `@bugadani` maybe? Feel free to reassign :)
    Dylan-DPC authored Apr 5, 2021
    Configuration menu
    Copy the full SHA
    5d3e75e View commit details
    Browse the repository at this point in the history
  10. Rollup merge of rust-lang#83881 - lnicola:rust-analyzer-2021-04-05, r…

    …=jonas-schievink
    
    ⬆️ rust-analyzer
    Dylan-DPC authored Apr 5, 2021
    Configuration menu
    Copy the full SHA
    aa90164 View commit details
    Browse the repository at this point in the history
  11. Rollup merge of rust-lang#83885 - jyn514:private-links, r=Mark-Simula…

    …crum
    
    Document compiler/ with -Aprivate-intra-doc-links
    
    Since compiler/ always passes --document-private-items, it's ok to link to items that are private.
    Dylan-DPC authored Apr 5, 2021
    Configuration menu
    Copy the full SHA
    c033098 View commit details
    Browse the repository at this point in the history