-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Account for bad placeholder errors on consts/statics with trait objects #83739
Conversation
This comment has been minimized.
This comment has been minimized.
looks good to me r? @Dylan-DPC @bors r+ rollup=never p=5 |
📌 Commit 79f0bcc64ab92684cb702f785e017544d67c22ae has been approved by |
@Dylan-DPC Hm, I don't think you're on the t-compiler, the release team can approve such a PR? And rollup status and priority don't seem suitable. |
uggh yeah wrong rollup option my bad |
@bors p=0 rollup=always |
normally it's fine for smaller trivial prs. But if you want someone from compiler team to look at it, let me know. Not an issue |
I'd ask a review from the compiler team to check if we don't have a diagnostic regression like #77431 (comment). |
bah.. r? @estebank |
Friendly-ping @estebank, I guess you overlooked this? |
@bors r+ @JohnTitor sorry, I've been out for the past few weeks. |
📌 Commit 052d77e has been approved by |
No problem, thanks for reviewing! |
Account for bad placeholder errors on consts/statics with trait objects Fixes rust-lang#75889 r? `@estebank`
Rollup of 8 pull requests Successful merges: - rust-lang#83739 (Account for bad placeholder errors on consts/statics with trait objects) - rust-lang#85637 (document PartialEq, PartialOrd, Ord requirements more explicitly) - rust-lang#86152 (Lazify is_really_default condition in the RustdocGUI bootstrap step) - rust-lang#86156 (Fix a bug in the linkchecker) - rust-lang#86427 (Updated release note) - rust-lang#86452 (fix panic-safety in specialized Zip::next_back) - rust-lang#86484 (Do not set depth to 0 in fully_expand_fragment) - rust-lang#86491 (expand: Move some more derive logic to rustc_builtin_macros) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
…yn-obj, r=pnkfelix Harden bad placeholder checks on statics/consts Resubmission of rust-lang#89161 Fixes rust-lang#88643 In rust-lang#83739, I added a check for trait objects on statics/consts but it wasn't robust. `is_suggestable_infer_ty` fn does a more strict check and finds more bad placeholders. See rust-lang#89161 (comment) for the more detailed explanation. r? `@pnkfelix` as you're the reviewer of the previous PR
Fixes #75889
r? @estebank