-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add targets that were missing in rustc #83724
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @estebank (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
Co-authored-by: Jonas Schievink <[email protected]>
This comment has been minimized.
This comment has been minimized.
You'll have to add these to https://github.com/rust-lang/rust/blob/master/src/doc/rustc/src/platform-support.md as Tier 3 targets, so that CI will pass |
Hm, so before we merge this I would like to see the tier 3 policy requirements explicitly documented (e.g., in a comment here and a list of the maintainers). You can see a sample of how this might be done in rust-lang/compiler-team#428 (comment), though note that MCP is seeking a slightly higher bar (Tier 2). That particular comment just addresses tier 3 status, though. |
Would this be acceptable? I'm still a newbie at this. |
r? @joshtriplett -- I seem to recall you having some familiarity with the relevant distinctions between i{3,4,5,6}86 targets and maybe can be a better judge of the appropriate decision here based on the writeup. My not well informed feeling is that we may want separate (or at least declared) maintainers for these targets, seeing as I believe they bring somewhat more "interesting" requirements compared to the 5/6 targets which seem to already have. |
Yeah, these targets absolutely need separate maintainers listed. Just because someone maintains i686 targets does not mean it's safe to assume they want to maintain these much older, less widely used targets. (For that matter, we should probably determine who the maintainers of the i586 targets are, which is likely separate from the maintainers of i686.) |
Moving this to "waiting-on-author", as it needs maintainers in order to move forward. |
Added |
@Sycration @rustbot label: +S-inactive |
The 1.51 release notes said that i386 and i486 linux were supported, but it was not included in rustc. This adds those.