Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add targets that were missing in rustc #83724

Closed
wants to merge 3 commits into from

Conversation

Sycration
Copy link

The 1.51 release notes said that i386 and i486 linux were supported, but it was not included in rustc. This adds those.

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @estebank (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 31, 2021
@rust-log-analyzer

This comment has been minimized.

@jonas-schievink
Copy link
Contributor

You'll have to add these to https://github.com/rust-lang/rust/blob/master/src/doc/rustc/src/platform-support.md as Tier 3 targets, so that CI will pass

@crlf0710 crlf0710 added A-target-specs Area: Compile-target specifications S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 17, 2021
@JohnCSimon JohnCSimon added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 4, 2021
@bstrie bstrie added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 19, 2021
@crlf0710
Copy link
Member

crlf0710 commented Jun 5, 2021

r? @Mark-Simulacrum

@Mark-Simulacrum
Copy link
Member

Hm, so before we merge this I would like to see the tier 3 policy requirements explicitly documented (e.g., in a comment here and a list of the maintainers).

You can see a sample of how this might be done in rust-lang/compiler-team#428 (comment), though note that MCP is seeking a slightly higher bar (Tier 2). That particular comment just addresses tier 3 status, though.

@Mark-Simulacrum Mark-Simulacrum added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 6, 2021
@Sycration
Copy link
Author

Hm, so before we merge this I would like to see the tier 3 policy requirements explicitly documented (e.g., in a comment here and a list of the maintainers).

You can see a sample of how this might be done in rust-lang/compiler-team#428 (comment), though note that MCP is seeking a slightly higher bar (Tier 2). That particular comment just addresses tier 3 status, though.

Would this be acceptable? I'm still a newbie at this.

@Mark-Simulacrum Mark-Simulacrum added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 14, 2021
@Mark-Simulacrum
Copy link
Member

r? @joshtriplett -- I seem to recall you having some familiarity with the relevant distinctions between i{3,4,5,6}86 targets and maybe can be a better judge of the appropriate decision here based on the writeup. My not well informed feeling is that we may want separate (or at least declared) maintainers for these targets, seeing as I believe they bring somewhat more "interesting" requirements compared to the 5/6 targets which seem to already have.

@JohnCSimon JohnCSimon added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 6, 2021
@joshtriplett
Copy link
Member

Yeah, these targets absolutely need separate maintainers listed. Just because someone maintains i686 targets does not mean it's safe to assume they want to maintain these much older, less widely used targets.

(For that matter, we should probably determine who the maintainers of the i586 targets are, which is likely separate from the maintainers of i686.)

@JohnCSimon JohnCSimon added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 15, 2021
@inquisitivecrystal inquisitivecrystal added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Aug 24, 2021
@JohnCSimon JohnCSimon added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 13, 2021
@JohnCSimon JohnCSimon added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 28, 2021
@joshtriplett joshtriplett added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 4, 2021
@joshtriplett
Copy link
Member

Moving this to "waiting-on-author", as it needs maintainers in order to move forward.

@JohnCSimon JohnCSimon added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 24, 2021
@JohnCSimon JohnCSimon added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 13, 2021
@camelid camelid added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 10, 2021
@joelpalmer joelpalmer added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 1, 2022
@JohnCSimon JohnCSimon added the S-blocked Status: Blocked on something else such as an RFC or other implementation work. label Feb 27, 2022
@JohnCSimon
Copy link
Member

Added S-blocked because it's waiting on maintainers.
cc @Sycration @joshtriplett

@Dylan-DPC Dylan-DPC removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Mar 26, 2022
@JohnCSimon
Copy link
Member

@Sycration
Ping from triage: I'm closing this due to inactivity, Please reopen when you are ready to continue with this.
Note: if you do please open the PR BEFORE you push to it, else you won't be able to reopen - this is a quirk of github.
Thanks for your contribution.

@rustbot label: +S-inactive

@JohnCSimon JohnCSimon closed this Nov 27, 2022
@rustbot rustbot added the S-inactive Status: Inactive and waiting on the author. This is often applied to closed PRs. label Nov 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-target-specs Area: Compile-target specifications S-blocked Status: Blocked on something else such as an RFC or other implementation work. S-inactive Status: Inactive and waiting on the author. This is often applied to closed PRs. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.