-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Self keyword doc URL conflict on case insensitive file systems (until definitely fixed on rustdoc) #83678
Fix Self keyword doc URL conflict on case insensitive file systems (until definitely fixed on rustdoc) #83678
Conversation
@GuillaumeGomez could you double check this generates rust/src/librustdoc/formats/renderer.rs Line 140 in 106da77
|
You need to update rust/compiler/rustc_lint/src/internal.rs Lines 280 to 283 in 16156fb
|
Err actually I think I would just |
This comment has been minimized.
This comment has been minimized.
Sure, adding a test for it then.
I intended to do that. :3 (and yet another lint I added which prevents me from doing bad things. Sorry past me...) |
9038279
to
f35e587
Compare
Actually, testing the existence of a file isn't that easy. But I can confirm that the |
📌 Commit f35e587 has been approved by |
What about something like this? #![crate_name = "foo"]
#[doc(keyword = "banana")]
mod banana_keyword {}
// @has foo/keyword.banana.html '' |
…nflict, r=jyn514 Fix Self keyword doc URL conflict on case insensitive file systems (until definitely fixed on rustdoc) This is just a hack to allow rustup to work on macOS and windows again to distribute std documentation (hopefully once rust-lang/rfcs#3097 or an equivalent is merged). Fixes rust-lang#80504. Prevents rust-lang#83154 and rust-lang/rustup#2694 in future releases. cc `@kinnison` r? `@jyn514`
Rollup of 6 pull requests Successful merges: - rust-lang#80720 (Make documentation of which items the prelude exports more readable.) - rust-lang#83654 (Do not emit a suggestion that causes the E0632 error) - rust-lang#83671 (Add a regression test for issue-75801) - rust-lang#83678 (Fix Self keyword doc URL conflict on case insensitive file systems (until definitely fixed on rustdoc)) - rust-lang#83680 (Update for loop desugaring docs) - rust-lang#83683 (bootstrap: don't complain about linkcheck if it is excluded) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
beta backport decision deferred to next week |
Hmm, maybe we should also add a note to the |
…nflict, r=jyn514 Fix Self keyword doc URL conflict on case insensitive file systems (until definitely fixed on rustdoc) This is just a hack to allow rustup to work on macOS and windows again to distribute std documentation (hopefully once rust-lang/rfcs#3097 or an equivalent is merged). Fixes rust-lang#80504. Prevents rust-lang#83154 and rust-lang/rustup#2694 in future releases. cc ``@kinnison`` r? ``@jyn514``
[beta] Beta rollups - Upgrade expat dependency in riscv64 to newer version. rust-lang#84394 - Fix Self keyword doc URL conflict on case insensitive file systems (until definitely fixed on rustdoc) rust-lang#83678 - Cargo: - Backport "Don't give a hard error when the end-user specifies RUSTC_BOOTSTRAP=crate_name" (rust-lang/cargo#9385) - [beta] Revert rust-lang/cargo#9133, moving to git HEAD dependencies by default (rust-lang/cargo#9383)
This is just a hack to allow rustup to work on macOS and windows again to distribute std documentation (hopefully once rust-lang/rfcs#3097 or an equivalent is merged).
Fixes #80504. Prevents #83154 and rust-lang/rustup#2694 in future releases.
cc @kinnison
r? @jyn514