Update Clippy #83480
Merged
Update Clippy #83480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes rust-lang#6803 changelog: upper_case_acronyms: ignore public items
When a method starts with `to_` and ends with `_mut`, it should expect a `&mut self` parameter, otherwise `&self`.
This will be removed in the next sync, once beta is at 1.52. Until then this hack avoids to put `cfg(bootstrap)` into Clippy.
…tion a bit clearer
Use sym::Iterator instead of paths::ITERATOR Since `sym::Iterator` was added to diagnostic_item, it's time to remove `paths::ITERATOR`. ref: rust-lang#5393 changelog: Add `is_trait_method` to `clippy_utils` changelog: Remove `paths::ITERATOR`
inconsistent_struct_constructor: try to make message and lint description a bit clearer changelog: inconsistent_struct_constructor: try to make message and lint description a bit clearer r? `@ghost`
Fix suggestion for `explicit_deref_methods`. Sometimes `&**` is needed, sometimes nothing is needed. Allow `explicit_deref_methods` to trigger in a few new contexts. `explicit_deref_methods` will now consider ufcs calls
Remove more unnecessary code
`explicit_deref_methods` improvements Breaking up rust-lang#6837 changelog: `explicit_deref_methods` will lint chained `deref` calls and ufcs style calls
…_with_default_with_other_ctors, r=phansch mem_replace_with_default: recognize some std library ctors fixes rust-lang#6562 changelog: mem_replace_with_default: recognize some common constructors equivalent to `Default::default()`
…iraffate Implement new lint: if_then_some_else_none Resolves rust-lang#6760 changelog: Added a new lint: `if_then_some_else_none`
replace span_lint with span_lint_and_sugg along with error message fixes: rust-lang#6874 changelog: none apologies if this may not be the most idiomatic way of doing it, any advice on changes (if any) would be greatly appreciated.
…latten, r=llogiq Fix false positive in `manual_flatten` This pull request fixes false positive in `manual_flatten` in case using a slice of references . closes: rust-lang#6893 changelog: fix false positive in `manual_flatten`
…different generic arguments
Fix `new_ret_no_self` false positive fixes: rust-lang#1724 changelog: Fix false positive with `new_ret_no_self` when returning `Self` with different generic arguments
apply changes from review
Check for `.to_string().into_bytes()` in string_lit_to_bytes fixes rust-lang#6927 changelog: Add a check for `into_bytes()` to string_lit_to_bytes lint
Rustup r? `@ghost` changelog: none
|
Some changes occurred in src/tools/clippy. cc @rust-lang/clippy |
rust-highfive
added
the
S-waiting-on-review
|
@bors rollup=iffy (Cargo.lock file modified) |
|
r? @Dylan-DPC @bors r+ |
|
📌 Commit 0f1ff45 has been approved by |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bi-weekly Clippy update.
r? @Manishearth