Re-enable rusti tests #8321
Closed
Re-enable rusti tests #8321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@alexcrichton if this causes breakage, will it bounce, or will it nondeterministically break other PRs? |
|
Well there's a few things it could do. If it bounces, then that's great. Otherwise it could nondeterministically break. I believe that I know the cause of the "nondeterministic" breakage, and it should be fixed now. If this does start causing problems, though, I'll continue investigating. |
bors
added a commit
that referenced
this pull request
Aug 6, 2013
Now that LLVM has been upgraded, I think that we can try again to re-enable the rusti tests.
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Feb 26, 2022
…amsteffen fix false positives of large_enum_variant fixes: rust-lang#8321 The size of enums containing generic type was calculated to be 0. I changed [large_enum_variant] so that such enums are not linted. changelog: none
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that LLVM has been upgraded, I think that we can try again to re-enable the rusti tests.