Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't encode file information for span with a dummy location #83132

Merged
merged 1 commit into from
Mar 15, 2021

Commits on Mar 15, 2021

  1. Don't encode file information for span with a dummy location

    Fixes rust-lang#83112
    
    The location information for a dummy span isn't real, so don't encode
    it. This brings the incr comp cache code into line with the Span
    `StableHash` impl, which doesn't hash the location information for dummy
    spans.
    
    Previously, we would attempt to load the 'original' file from a dummy
    span - if the file id changed (e.g. due to being moved on disk), we would get an
    ICE, since the Span was still valid due to its hash being unchanged.
    Aaron1011 committed Mar 15, 2021
    Configuration menu
    Copy the full SHA
    7429c68 View commit details
    Browse the repository at this point in the history