Signed-off-by: Ian Jackson <[email protected]>

Closes rust-lang#73125

This is in pursuance of
  Issue rust-lang#73127 Consider adding #[must_use] to std::process::ExitStatus

In
  MR rust-lang#81452 Add #[must_use] to [...] process::ExitStatus
we concluded that the existing arrangements in are too awkward
so adding that #[must_use] is blocked on improving the ergonomics.

I wrote a mini-RFC-style discusion of the approach in
  rust-lang#73125 (comment)

Signed-off-by: Ian Jackson <[email protected]>

It is unergnomic to have to say things like
   bad.into_status().signal()

Implementing `ExitStatusExt` for `ExitStatusError` fixes this.
Unfortunately it does mean making a previously-infallible method
capable of panicing, although of course the existing impl remains
infallible.

The alternative would be a whole new `ExitStatusErrorExt` trait.

`<ExitStatus as ExitStatusExt>::into_raw()` is not particularly
ergonomic to call because of the often-required type annotation.
See for example the code in the test case in
  library/std/src/sys/unix/process/process_unix/tests.rs

Perhaps we should provide equivalent free functions for `ExitStatus`
and `ExitStatusExt` in std::os::unix::process and maybe deprecate this
trait method.  But I think that is for the future.

Signed-off-by: Ian Jackson <[email protected]>

Co-authored-by: Josh Triplett <[email protected]>

Co-authored-by: Jane Lusby <[email protected]>

Signed-off-by: Ian Jackson <[email protected]>

We should revert this commit when this is stabilised.

Signed-off-by: Ian Jackson <[email protected]>