Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustdoc: Get TyCtxt from self instead of passing as argument in AutoTraitFinder #82597

Merged
merged 1 commit into from
Mar 2, 2021
Merged

rustdoc: Get TyCtxt from self instead of passing as argument in AutoTraitFinder #82597

merged 1 commit into from
Mar 2, 2021

Conversation

noslaver
Copy link
Contributor

@noslaver noslaver commented Feb 27, 2021 •
edited by estebank
Loading

First contribution 🦀, let me know if anything is amiss.

Fix #82137.

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @GuillaumeGomez (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 27, 2021
@noslaver noslaver changed the title Closes #82137 Fix issue #82137 Feb 27, 2021
@ehuss
Copy link
Contributor

ehuss commented Feb 27, 2021

Just a tip, using a descriptive PR title and commit message is helpful. When reading the git log, seeing something like "fix issue #82137" doesn't really have any context, and seeing a PR title also has similar issues. It can be helpful when commit messages stand on their own, where they explain what the change is and why it is being made.

Git has some guidelines for commit messages.

@GuillaumeGomez GuillaumeGomez added C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Feb 27, 2021
@GuillaumeGomez
Copy link
Member

Looks good to me. Since it also changes some code in the compiler, I'll wait for someone from @rust-lang/compiler to approve it as well.

@nagisa
Copy link
Member

nagisa commented Feb 27, 2021

r=me with ehuss' comment addressed.

@noslaver
Copy link
Contributor Author

r=me with ehuss' comment addressed.

Updated git comment, should I update the PR title as well?

@GuillaumeGomez
Copy link
Member

Yes please.

@noslaver noslaver changed the title Fix issue #82137 Fix #82137 - Get TyCtxt from self instead of passing as argument in AutoTraitFinder Feb 28, 2021
@bors
Copy link
Contributor

bors commented Feb 28, 2021

☔ The latest upstream changes (presumably #81349) made this pull request unmergeable. Please resolve the merge conflicts.

@estebank estebank changed the title Fix #82137 - Get TyCtxt from self instead of passing as argument in AutoTraitFinder Get TyCtxt from self instead of passing as argument in AutoTraitFinder Mar 1, 2021
@estebank
Copy link
Contributor

estebank commented Mar 1, 2021

There's now a merge conflict. You will have to checkout a recent master and rebase on top of it.

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@wesleywiser
Copy link
Member

@bors r=nagisa

@bors
Copy link
Contributor

bors commented Mar 1, 2021

📌 Commit 854fffd has been approved by nagisa

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 1, 2021
jyn514
jyn514 approved these changes Mar 2, 2021
View reviewed changes
Copy link
Member

@jyn514 jyn514 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thanks!

@JohnTitor JohnTitor mentioned this pull request Mar 2, 2021
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 2, 2021
@bors
Auto merge of rust-lang#82698 - JohnTitor:rollup-htd533c, r=JohnTitor
67342b8 
Rollup of 10 pull requests

Successful merges:

 - rust-lang#80189 (Convert primitives in the standard library to intra-doc links)
 - rust-lang#80874 (Update intra-doc link documentation to match the implementation)
 - rust-lang#82376 (Add option to enable MIR inlining independently of mir-opt-level)
 - rust-lang#82516 (Add incomplete feature gate for inherent associate types.)
 - rust-lang#82579 (Fix turbofish recovery with multiple generic args)
 - rust-lang#82593 (Teach rustdoc how to display WASI.)
 - rust-lang#82597 (Get TyCtxt from self instead of passing as argument in AutoTraitFinder)
 - rust-lang#82627 (Erase late bound regions to avoid ICE)
 - rust-lang#82661 (:arrow_up: rust-analyzer)
 - rust-lang#82691 (Update books)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 43bcfdb into rust-lang:master Mar 2, 2021
@rustbot rustbot added this to the 1.52.0 milestone Mar 2, 2021
@GuillaumeGomez GuillaumeGomez mentioned this pull request Mar 2, 2021
Closed
@noslaver noslaver deleted the fix-82137 branch March 3, 2021 07:54
@jyn514 jyn514 changed the title Get TyCtxt from self instead of passing as argument in AutoTraitFinder rustdoc: Get TyCtxt from self instead of passing as argument in AutoTraitFinder Mar 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jyn514 jyn514 jyn514 approved these changes

@GuillaumeGomez GuillaumeGomez GuillaumeGomez approved these changes

Assignees

@GuillaumeGomez GuillaumeGomez

Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.52.0
Development

Successfully merging this pull request may close these issues.

Remove unnecessary tcx parameter to param_env_to_generics