Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

-Zunpretty: allow passing several printing modes as comma-separated list #82540

Closed
wants to merge 1 commit into from
Closed

-Zunpretty: allow passing several printing modes as comma-separated list #82540

wants to merge 1 commit into from

Conversation

matthiaskrgr
Copy link
Member

Modes that had a comma in them use "+" now:
-Zunpretty=expanded,hygiene => -Zunpretty=expanded+hygiene

You can now print several modes back to back like this:
-Zunpretty=expanded+hygiene,mir,hir,everybody_loops

Note: everybody_loops modifies the IR which can influence output of other printing modes.

@rust-highfive
Copy link
Collaborator

r? @varkor

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 26, 2021
@jyn514 jyn514 added requires-nightly This issue requires a nightly compiler in some way. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 26, 2021
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@matthiaskrgr matthiaskrgr marked this pull request as draft February 26, 2021 09:39
@matthiaskrgr
Copy link
Member Author

Note to self: something broke while rebasing from #82269

error: internal compiler error: unexpected panic

note: the compiler unexpectedly panicked. this is a bug.

note: we would appreciate a bug report: https://github.com/rust-lang/rust/issues/new?labels=C-bug%2C+I-ICE%2C+T-compiler&template=ice.md

note: rustc 1.52.0-dev running on x86_64-unknown-linux-gnu

note: compiler flags: -Z unpretty=expanded,mir

@matthiaskrgr
-Zunpretty: allow passing several printing modes as comma-separated l…
1de1360 
…ist.

Modes that had a comma in them use "+" now:
-Zunpretty=expanded,hygiene => -Zunpretty=expanded+hygiene

You can print several modes back to back like this: -Zunpretty=expanded+hygiene,mir,hir,everybody_loops
@LeSeulArtichaut
Copy link
Contributor

FYI, this will also conflict with #82304

@bors
Copy link
Contributor

bors commented Mar 4, 2021

☔ The latest upstream changes (presumably #82304) made this pull request unmergeable. Please resolve the merge conflicts.

@varkor
Copy link
Member

varkor commented Mar 7, 2021

@matthiaskrgr: is this ready to review?

@matthiaskrgr
Copy link
Member Author

No, sorry.
There are merge conflicts and I'll need to fix some runtime bugs which is why I converted to a draft.

@varkor varkor added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LeSeulArtichaut LeSeulArtichaut LeSeulArtichaut left review comments

Assignees

@varkor varkor

Labels
requires-nightly This issue requires a nightly compiler in some way. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@matthiaskrgr @rust-highfive @rust-log-analyzer @LeSeulArtichaut @bors @varkor @jyn514