Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve non_fmt_panic lint. #82113

Merged
merged 9 commits into from
Feb 23, 2021
Merged

Improve non_fmt_panic lint. #82113

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
ef778e7
Fix span in non_fmt_panic for panic!(some_macro!()).
m-ou-se Feb 14, 2021
1abc1e2
Add test for non_fmt_panic lint for panic!(some_macro!()).
m-ou-se Feb 14, 2021
a428ab1
Improve suggestion for panic!(format!(..)).
m-ou-se Feb 14, 2021
9f97a0b
Add test for panic!(format!(..)) lint.
m-ou-se Feb 14, 2021
37c532c
Suggest correct replacement for panic![123].
m-ou-se Feb 14, 2021
8ad12bb
Add ui tests for panic![123] and panic!{123}.
m-ou-se Feb 14, 2021
2a0c424
Formatting.
m-ou-se Feb 14, 2021
daa371d
Only define rustc_diagnostic_item format_macro in not(test).
m-ou-se Feb 14, 2021
ad93f48
Add comment about how we find the right span in non_fmt_panic.
m-ou-se Feb 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/test/ui/non-fmt-panic.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,12 @@ fn main() {
fancy_panic::fancy_panic!(S);
//~^ WARN panic message is not a string literal

macro_rules! a {
() => { 123 };
}

panic!(a!()); //~ WARN panic message is not a string literal
jyn514 marked this conversation as resolved.
Show resolved Hide resolved

// Check that the lint only triggers for std::panic and core::panic,
// not any panic macro:
macro_rules! panic {
Expand Down
18 changes: 17 additions & 1 deletion src/test/ui/non-fmt-panic.stderr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,5 +183,21 @@ LL | fancy_panic::fancy_panic!(S);
|
= note: this is no longer accepted in Rust 2021

warning: 14 warnings emitted
warning: panic message is not a string literal
--> $DIR/non-fmt-panic.rs:36:12
|
LL | panic!(a!());
| ^^^^
|
= note: this is no longer accepted in Rust 2021
help: add a "{}" format string to Display the message
|
LL | panic!("{}", a!());
| ^^^^^
help: or use std::panic::panic_any instead
|
LL | std::panic::panic_any(a!());
| ^^^^^^^^^^^^^^^^^^^^^^

warning: 15 warnings emitted