Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

const_evaluatable: expand abstract consts in try_unify #81426

Merged
merged 3 commits into from
Jan 28, 2021
Merged

const_evaluatable: expand abstract consts in try_unify #81426

merged 3 commits into from
Jan 28, 2021

Conversation

BoxyUwU
Copy link
Member

@BoxyUwU BoxyUwU commented Jan 27, 2021

See this zulip topic for more info

cc @lcnr
r? @oli-obk

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 27, 2021
@lcnr lcnr added A-const-generics Area: const generics (parameters and arguments) F-generic_const_exprs `#![feature(generic_const_exprs)]` labels Jan 27, 2021
@oli-obk
Copy link
Contributor

oli-obk commented Jan 27, 2021

Holy 🐮 thanks! This was fast and is much better than I anticipated.

@oli-obk
Copy link
Contributor

oli-obk commented Jan 27, 2021

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Jan 27, 2021

📌 Commit f426177 has been approved by oli-obk

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 27, 2021
@rust-log-analyzer
Copy link
Collaborator

The job mingw-check failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot) 
Successfully built 1013c55bd866
Successfully tagged rust-ci:latest
Built container sha256:1013c55bd866513c20961a72c96c8d3cbc7f0ba286d6344fdcbbdfdbb1a0d285
Uploading finished image to https://ci-caches.rust-lang.org/docker/80afe504501370b4d310121e20e04a989f302196b07831c4375b96e05bc067556c2046e20ab2062b28a9dc9b2ae132b37d419cc55a065dfcd25501527e829ab9
upload failed: - to s3://rust-lang-ci-sccache2/docker/80afe504501370b4d310121e20e04a989f302196b07831c4375b96e05bc067556c2046e20ab2062b28a9dc9b2ae132b37d419cc55a065dfcd25501527e829ab9 Unable to locate credentials
[CI_JOB_NAME=mingw-check]
---
configure: rust.channel         := nightly
configure: rust.debug-assertions := True
configure: llvm.assertions      := True
configure: dist.missing-tools   := True
configure: build.configure-args := ['--enable-sccache', '--disable-manage-submodu ...
configure: writing `config.toml` in current directory
configure: 
configure: run `python /checkout/x.py --help`
configure: 
---
Checking which error codes lack tests...
Found 435 error codes
Found 0 error codes with no tests
Done!
tidy error: /checkout/src/test/ui/const-generics/const_evaluatable_checked/nested_uneval_unification-2.rs:28: line longer than 100 chars
tidy error: /checkout/src/test/ui/const-generics/const_evaluatable_checked/nested_uneval_unification-1.rs:34: line longer than 100 chars
tidy error: /checkout/src/test/ui/const-generics/const_evaluatable_checked/nested-abstract-consts-2.rs:34: line longer than 100 chars
some tidy checks failed

command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/tidy" "/checkout" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "/checkout/obj/build"
expected success, got: exit code: 1

@oli-obk
Copy link
Contributor

oli-obk commented Jan 27, 2021

@bors r-

tidy is unhappy. You can run it locally with ./x.py test src/tools/tidy

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 27, 2021
@oli-obk
Copy link
Contributor

oli-obk commented Jan 27, 2021

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Jan 27, 2021

📌 Commit ab421a1 has been approved by oli-obk

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 27, 2021
This was referenced Jan 27, 2021
Closed
Closed
@JohnTitor JohnTitor mentioned this pull request Jan 28, 2021
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 28, 2021
@bors
Auto merge of rust-lang#81461 - JohnTitor:rollup-b0ij25f, r=JohnTitor
0e19020 
Rollup of 13 pull requests

Successful merges:

 - rust-lang#70904 (Stabilize `Seek::stream_position` (feature `seek_convenience`))
 - rust-lang#79951 (Refractor a few more types to `rustc_type_ir` )
 - rust-lang#80868 (Print failure message on all tests that should panic, but don't)
 - rust-lang#81062 (Improve diagnostics for Precise Capture)
 - rust-lang#81277 (Make more traits of the From/Into family diagnostic items)
 - rust-lang#81284 (Make `-Z time-passes` less noisy)
 - rust-lang#81379 (Improve URLs handling)
 - rust-lang#81416 (Tweak suggestion for missing field in patterns)
 - rust-lang#81426 (const_evaluatable: expand abstract consts in try_unify)
 - rust-lang#81428 (compiletest: Add two more unit tests)
 - rust-lang#81430 (add const_evaluatable_checked test)
 - rust-lang#81433 (const_evaluatable: stop looking into type aliases)
 - rust-lang#81445 (Update cargo)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit f183e5f into rust-lang:master Jan 28, 2021
@rustbot rustbot added this to the 1.51.0 milestone Jan 28, 2021
@lcnr lcnr mentioned this pull request Dec 11, 2021
Closed
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oli-obk oli-obk oli-obk requested changes

Assignees

@oli-obk oli-obk

Labels
A-const-generics Area: const generics (parameters and arguments) F-generic_const_exprs `#![feature(generic_const_exprs)]` S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.51.0
Development

Successfully merging this pull request may close these issues.
7 participants
@BoxyUwU @oli-obk @bors @rust-log-analyzer @rust-highfive @lcnr @rustbot