Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce log level used by tracing instrumentation from info to debug #81350

Merged
merged 1 commit into from
Feb 11, 2021

Conversation

tmiasko
Copy link
Contributor

@tmiasko tmiasko commented Jan 24, 2021

Restore log level to debug to avoid make info log level overly verbose (the uses of instrument attribute modified there, were for the most part a replacement for debug!; one use was novel).

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 24, 2021
@nagisa
Copy link
Member

nagisa commented Jan 24, 2021

Could the description and/or the commit message be adjusted to include a few sentences outlining the rationale?

@oli-obk
Copy link
Contributor

oli-obk commented Jan 25, 2021

is there a way to set the default #[instrument] log level (maybe via a tracing crate feature or sth)?

@tmiasko
Copy link
Contributor Author

tmiasko commented Jan 25, 2021

I think it is impossible to change the default currently.

@oli-obk
Copy link
Contributor

oli-obk commented Jan 25, 2021

Ok, then let's do this.

One rationale could be to not have these spans in the regular rustc, but only in the debug-assertions version

@lcnr
Copy link
Contributor

lcnr commented Feb 11, 2021

@bors r+ rollup

I think it is impossible to change the default currently.

I don't know much about tracing but would it make sense to open an issue about this? I think having instrument default to debug makes sense for rustc.

@bors
Copy link
Contributor

bors commented Feb 11, 2021

📌 Commit 59457ab has been approved by lcnr

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 11, 2021
@oli-obk
Copy link
Contributor

oli-obk commented Feb 11, 2021

Tracing 0.2 will remove the default and require a specification of the level for every use of the macro: tokio-rs/tracing#1122

@Mark-Simulacrum
Copy link
Member

@bors rollup=never - I'm worried this could have perf implications

@bors
Copy link
Contributor

bors commented Feb 11, 2021

⌛ Testing commit 59457ab with merge 26e5bcd...

@bors
Copy link
Contributor

bors commented Feb 11, 2021

☀️ Test successful - checks-actions
Approved by: lcnr
Pushing 26e5bcd to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Feb 11, 2021
@bors bors merged commit 26e5bcd into rust-lang:master Feb 11, 2021
@rustbot rustbot added this to the 1.52.0 milestone Feb 11, 2021
@tmiasko tmiasko deleted the instrument-debug branch February 11, 2021 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants