Update BARE_TRAIT_OBJECTS lint to deny in 2021 edition #81244
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
jyn514
added
D-edition
crlf0710
added
S-waiting-on-review
|
@rylev -- do you plan to open a consolidated pr? should we close this one for now? |
|
Yep, let's close this for now. |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 4, 2021
…atsakis Update BARE_TRAIT_OBJECT and ELLIPSIS_INCLUSIVE_RANGE_PATTERNS to errors in Rust 2021 This addresses rust-lang#81244 by updating two lints to errors in the Rust 2021 edition. r? `@estebank`
flip1995
pushed a commit
to flip1995/rust-clippy
that referenced
this pull request
May 6, 2021
Update BARE_TRAIT_OBJECT and ELLIPSIS_INCLUSIVE_RANGE_PATTERNS to errors in Rust 2021 This addresses rust-lang/rust#81244 by updating two lints to errors in the Rust 2021 edition. r? `@estebank`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of #80165 this upgrades the
BARE_TRAIT_OBJECTSlint fromWarntoDenyin the 2021 edition. In practice this doesn't change very much as the compiler is still compiled in 2018 edition.There is active discussion on whether a deny by default lint is the right path or whether this should be handled in another part of the compiler as a hard error. This PR can be used to further that discussion.
r? @nikomatsakis