Rollup of 11 pull requests #81240
Merged
Rollup of 11 pull requests #81240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The heading style for `std::prelude` is to be consistent with the headings for `std` and `core`: `# The Rust Standard Library` and `# The Rust Core Library`, respectively.
No functional changes intended
As it was suggested in rust-lang#81037 `SpecFromIter` is not in the scope and therefore (even it should fail), we get a warning when we try do document private intems in `rust/library/alloc/`. This fixes rust-lang#81037 by adding the trait in the scope and also adding an `allow(unused_imports)` flag so that the compiler does not complain, Since the trait is not used per se in the code, it's just needed to have properly documented docs.
It's called at the same time and in the same place as `after_krate`, so they can be combined.
formating -> formatting
Visualize vector while differentiating between stack and heap. Inspired by cheats.rs, as this is probably the first place beginner go, they could understand stack and heap, length and capacity with this. Not sure if adding this means we should add to other places too. Superseeds rust-lang#76066
Suggested by oli-obk
Update the sample code to not create an insecure temporary file.
Co-authored-by: Mara Bos <[email protected]>
Add Vec visualization to understand capacity Visualize vector while differentiating between stack and heap. Inspired by cheats.rs, as this is probably the first place beginner go, they could understand stack and heap, length and capacity with this. Not sure if adding this means we should add to other places too. Superseeds rust-lang#76066 r? `@m-ou-se` cc `@the8472` I put back the order of the fields as it feels weird, the note already explains that the order of fields is not guaranteed
…ct, r=steveklabnik Use consistent punctuation for 'Prelude contents' docs
…acrum Add regression test for mutual recursion in obligation forest Add regression test for rust-lang#75860 with a slightly smaller example. I was looking at what caused the issue and was surprised when it errors out on nightly, so I just added a regression test which should effectively close the issue, altho it would be nice to find the fix for reference. Also I found that 80066 is not fixed by whatever fixed 75860.
…mar, r=m-ou-se
Improve grammar in documentation of format strings
The docs previously were
* using some weird `<` and `>` around some nonterminals
* _correct me if these **did** have any meaning_
* using of a (not explicitly defined) `text` nonterminal that didn’t explicitly disallow productions containing `'{'` or `'}'`
* incorrect in not allowing for `x?` and `X?` productions of `type`
* unnecessarily ambiguous, both
* allowing `type` to be `''`, and
* using an optional `[type]`
* using inconsistent underscore/hyphenation style between `format_string` and `format_spec` vs `maybe-format`
_Rendered:_
_(current docs: https://doc.rust-lang.org/nightly/std/fmt/#syntax)_
```@rustbot``` modify labels: T-doc
…ebank Improve unknown external crate error This improves error messages when unknown items in the crate root are encountered. Fixes rust-lang#63799 r? ```@estebank```
Visit only terminators when removing landing pads No functional changes intended
…n514 Fix broken links with `--document-private-items` in the standard library As it was suggested in rust-lang#81037 `SpecFromIter` is not in the scope and therefore we get a warning when we try to do document private intems in `rust/library/alloc/`. This addresses rust-lang#81037 by adding the trait in the scope as ```@jyn514``` suggested and also adding an `allow(unused_imports)` flag so that the compiler does not complain, Since the trait is not used per se in the code, it's just needed to have properly documented docs.
Remove unnecessary `after_run` function It's called at the same time and in the same place as `after_krate`, so they can be combined.
Fix ICE in mir when evaluating SizeOf on unsized type Not quite ready yet. This tries to fix rust-lang#80742 as discussed on [Zulip topic][1], by using `delay_span_bug`. I don't understand what `delay_span_bug` does. It seems like my error message is never used. With this patch, in this program: ```rust #![allow(incomplete_features)] #![feature(const_evaluatable_checked)] #![feature(const_generics)] use std::fmt::Debug; use std::marker::PhantomData; use std::mem::size_of; struct Inline<T> where [u8; size_of::<T>() + 1]: , { _phantom: PhantomData<T>, buf: [u8; size_of::<T>() + 1], } impl<T> Inline<T> where [u8; size_of::<T>() + 1]: , { pub fn new(val: T) -> Inline<T> { todo!() } } fn main() { let dst = Inline::<dyn Debug>::new(0); // line 27 } ``` these errors are printed, both for line 27 (annotated line above): - "no function or associated item named `new` found for struct `Inline<dyn Debug>` in the current scope" - "the size for values of type `dyn Debug` cannot be known at compilation time" Second error makes sense, but I'm not sure about the first one and why it's even printed. Finally, I'm not sure about the span passing in `const_eval`. [1]: https://rust-lang.zulipchat.com/#narrow/stream/269128-miri/topic/Help.20fixing.20.2380742
Fix typo in counters.rs formating -> formatting
Document security implications of std::env::temp_dir Update the sample code to not create an insecure temporary file.
|
@bors r+ p=11 rollup=never |
|
📌 Commit d6c7a79 has been approved by |
bors
added
the
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
|
☀️ Test successful - checks-actions |
This was referenced Jan 21, 2021
Merged
|
There were perf regressions in this rollup. The only PR that seems like a likely culprit is #81178. @rust-timer make-pr-for cd0c54a |
|
The code changed in #81178 is responsible from removing unwind edges for Perf results:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
--document-private-itemsin the standard library #81179 (Fix broken links with--document-private-itemsin the standard library)after_runfunction #81184 (Remove unnecessaryafter_runfunction)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup