Add track_caller to .steal() #81125
Merged
Add track_caller to .steal() #81125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before: ``` thread 'rustc' panicked at 'attempt to read from stolen value', /home/joshua/rustc/compiler/rustc_data_structures/src/steal.rs:43:15 ``` After: ``` thread 'rustc' panicked at 'attempt to steal from stolen value', compiler/rustc_mir/src/transform/mod.rs:423:25 ```
rust-highfive
added
the
S-waiting-on-review
jyn514
added
A-contributor-roadblock
|
@bors r+ rollup |
|
📌 Commit 394d701 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 18, 2021
Rollup of 12 pull requests Successful merges: - rust-lang#81038 (Update Clippy) - rust-lang#81071 (rustc_parse_format: Fix character indices in find_skips) - rust-lang#81100 (prevent potential bug in `encode_with_shorthand`.) - rust-lang#81105 (Initialize a few variables directly) - rust-lang#81116 (ConstProp: Copy body span instead of querying it) - rust-lang#81121 (Avoid logging the whole MIR body in SimplifyCfg) - rust-lang#81123 (Update cmp.rs) - rust-lang#81125 (Add track_caller to .steal()) - rust-lang#81128 (validation test: turn some const_err back into validation failures) - rust-lang#81131 (Edit rustc_middle::ty::cast docs) - rust-lang#81142 (Replace let Some(..) = with .is_some()) - rust-lang#81153 (Remove unused linkcheck exceptions) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
eddyb
reviewed
Sep 24, 2021
Comment on lines
+33
to
36
| #[track_caller] | ||
| pub fn borrow(&self) -> MappedReadGuard<'_, T> { | ||
| ReadGuard::map(self.value.borrow(), |opt| match *opt { | ||
| None => panic!("attempted to read from stolen value"), |
There was a problem hiding this comment.
This PR only fixed .steal(), .borrow() has no effect because the panic! is in a closure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
After:
r? @lcnr