-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Encode optimized MIR of generators when emitting metadata #81003
Conversation
@bors r+ p=1 (regression fix) |
📌 Commit ea4cbff has been approved by |
hey @tmiasko does your PR also fix this:
oh, BTW: the |
Thanks, it looks like there are multiple issues there (and this PR fixes only one of them). |
Ok, I posted my code in #80998 and I see you altered your initial post. Thanks! |
☀️ Test successful - checks-actions |
@tmiasko @oli-obk this has some fairly significant performance regressions. Is there any way to mitigate that? |
Not really, these performance regressions were "gained" in #80718 (comment) due to us forgetting to encode something that is definitely necessary... at least for libraries, not sure whether it makes sense to emit most of this stuff for binaries, and not sure whether we do that at all, but it could be an easy win if we aren't doing it already. |
No description provided.